You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/31 12:26:14 UTC
[GitHub] [incubator-pegasus] GehaFearless opened a new pull request, #1148: feat: expose parameter success_if_exist for interface create_app
GehaFearless opened a new pull request, #1148:
URL: https://github.com/apache/incubator-pegasus/pull/1148
### What problem does this PR solve? <!--add issue link with summary if exists-->
https://github.com/apache/incubator-pegasus/issues/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] codecov-commenter commented on pull request #1148: feat: expose parameter success_if_exist for interface create_app
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1148:
URL: https://github.com/apache/incubator-pegasus/pull/1148#issuecomment-1362349928
# [Codecov](https://codecov.io/gh/apache/incubator-pegasus/pull/1148?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@9a6702a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage ? 53.30%
=========================================
Files ? 27
Lines ? 2527
Branches ? 0
=========================================
Hits ? 1347
Misses ? 1134
Partials ? 46
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1148: feat: expose parameter success_if_exist for interface create_app
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1148:
URL: https://github.com/apache/incubator-pegasus/pull/1148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1148: feat: expose parameter success_if_exist for interface create_app
Posted by GitBox <gi...@apache.org>.
empiredan commented on code in PR #1148:
URL: https://github.com/apache/incubator-pegasus/pull/1148#discussion_r1055043289
##########
src/shell/commands/table_management.cpp:
##########
@@ -631,21 +631,23 @@ bool create_app(command_executor *e, shell_context *sc, arguments args)
{
static struct option long_options[] = {{"partition_count", required_argument, 0, 'p'},
{"replica_count", required_argument, 0, 'r'},
+ {"fail_if_exist", no_argument, 0, 's'},
Review Comment:
```suggestion
{"fail_if_exist", no_argument, 0, 'f'},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org