You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/07/08 18:39:00 UTC

[jira] [Resolved] (ARROW-5777) [C++] BasicDecimal128 is a small object it doesn't always make sense to pass by const ref

     [ https://issues.apache.org/jira/browse/ARROW-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney resolved ARROW-5777.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.14.1

Issue resolved by pull request 4739
[https://github.com/apache/arrow/pull/4739]

> [C++] BasicDecimal128 is a small object it doesn't always make sense to pass by const ref
> -----------------------------------------------------------------------------------------
>
>                 Key: ARROW-5777
>                 URL: https://issues.apache.org/jira/browse/ARROW-5777
>             Project: Apache Arrow
>          Issue Type: Improvement
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.14.1
>
>          Time Spent: 12h 50m
>  Remaining Estimate: 0h
>
> For the builder use case we saw 10% improvement in performance by not using const ref.  
> Add benchmarks and look at where it makes sense to avoid passing by ref.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)