You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/04/04 18:49:23 UTC
[PR] Minor: improve TableReference docs [arrow-datafusion]
alamb opened a new pull request, #9952:
URL: https://github.com/apache/arrow-datafusion/pull/9952
## Which issue does this PR close?
## Rationale for this change
While reviewing https://github.com/apache/arrow-datafusion/pull/9933 from @comphead I noticed a few things that could be improved in the docs
## What changes are included in this PR?
Improve `TableReferenc` docs
## Are these changes tested?
Doc tests
## Are there any user-facing changes?
Better docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve TableReference docs [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9952:
URL: https://github.com/apache/arrow-datafusion/pull/9952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve TableReference docs [arrow-datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #9952:
URL: https://github.com/apache/arrow-datafusion/pull/9952#discussion_r1553227247
##########
datafusion/common/src/table_reference.rs:
##########
@@ -139,7 +142,7 @@ impl TableReference {
/// Convenience method for creating a [`TableReference::Partial`].
///
- /// As described on [`TableReference`] this does *NO* parsing at all.
+ /// As described on [`TableReference`] this does *NO* normalization at all.
Review Comment:
nit: technically the doc on `TableReference` doesn't make reference to `partial` or `full` functions as it only refers to `bare`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve TableReference docs [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #9952:
URL: https://github.com/apache/arrow-datafusion/pull/9952#discussion_r1553448379
##########
datafusion/common/src/table_reference.rs:
##########
@@ -139,7 +142,7 @@ impl TableReference {
/// Convenience method for creating a [`TableReference::Partial`].
///
- /// As described on [`TableReference`] this does *NO* parsing at all.
+ /// As described on [`TableReference`] this does *NO* normalization at all.
Review Comment:
That is a good call -- I have clarified in a1d5965fff9767f6d44088e547275e69edaa81bc. Thank you @Jefffrey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor: improve TableReference docs [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9952:
URL: https://github.com/apache/arrow-datafusion/pull/9952#issuecomment-2039849704
Thanks again @comphead and @Jefffrey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org