You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/10 12:34:08 UTC
[GitHub] [ozone] kerneltime opened a new pull request, #3502: HDDS-6869 Use UGI when checking Upgrade priv
kerneltime opened a new pull request, #3502:
URL: https://github.com/apache/ozone/pull/3502
## What changes were proposed in this pull request?
When checking for admin privileges in the OM Upgrade path, the check is
only run against the short name representation of the UGI. The check
should be done against variations of the user name. Ideally, the check
should be against UGI Objects but the admin list created also takes in a
string representation of the user name via config.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6869
## How was this patch tested?
Local secure cluster with an upgrade finalization test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 merged pull request #3502: HDDS-6869. Use UGI when checking Upgrade priv
Posted by GitBox <gi...@apache.org>.
errose28 merged PR #3502:
URL: https://github.com/apache/ozone/pull/3502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3502: HDDS-6869 Use UGI when checking Upgrade priv
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3502:
URL: https://github.com/apache/ozone/pull/3502#issuecomment-1152620285
> Thanks for the fix @kerneltime. We will also need to do this in `OzoneManagerStateMachine#preAppendTransaction`, which is where the prepare request is checked for admin privileges since it will start blocking log entries there. We should probably add an admin check for `OzoneManager#queryUpgradeFinalizationProgress` as well.
Fixing those in https://issues.apache.org/jira/browse/HDDS-6870
To keep cherry-picking simple and fixing this in a targetted manner keeping them separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org