You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (Jira)" <ji...@apache.org> on 2019/09/11 21:26:00 UTC
[jira] [Commented] (TEZ-4084) Tez local mode fails when distributed
cache creates link with parent
[ https://issues.apache.org/jira/browse/TEZ-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928012#comment-16928012 ]
TezQA commented on TEZ-4084:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 28m 7s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 21s{color} | {color:orange} tez-dag: The patch generated 1 new + 46 unchanged - 0 fixed = 47 total (was 46) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 7s{color} | {color:red} tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 7s{color} | {color:green} tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 27s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-dag |
| | Possible null pointer dereference in org.apache.tez.dag.app.launcher.TezLocalCacheManager.localize() due to return value of called method Dereferenced at TezLocalCacheManager.java:org.apache.tez.dag.app.launcher.TezLocalCacheManager.localize() due to return value of called method Dereferenced at TezLocalCacheManager.java:[line 103] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.2 Server=19.03.2 Image:yetus/tez:d4a62deee |
| JIRA Issue | TEZ-4084 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12980124/TEZ-4084.1.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 320a9d9066d8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 7a3e378 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| findbugs | v3.0.1 |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/162/artifact/out/diff-checkstyle-tez-dag.txt |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/162/artifact/out/new-findbugs-tez-dag.html |
| Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/162/testReport/ |
| Max. process+thread count | 220 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/162/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Tez local mode fails when distributed cache creates link with parent
> --------------------------------------------------------------------
>
> Key: TEZ-4084
> URL: https://issues.apache.org/jira/browse/TEZ-4084
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Jacob Tolar
> Assignee: Jacob Tolar
> Priority: Minor
> Attachments: TEZ-4084.1.patch
>
>
> If you configure distributed cache with 'target#parent/link' in Tez Local Mode, the file cannot be created and the job fails:
> {code:java}
> java.lang.IllegalArgumentException: Invalid prefix or suffix
> at java.nio.file.TempFileHelper.generatePath(TempFileHelper.java:63)
> at java.nio.file.TempFileHelper.create(TempFileHelper.java:127)
> at java.nio.file.TempFileHelper.createTempDirectory(TempFileHelper.java:173)
> at java.nio.file.Files.createTempDirectory(Files.java:950)
> at org.apache.tez.dag.app.launcher.TezLocalCacheManager.localize(TezLocalCacheManager.java:103) {code}
>
> I propose:
> # Ensure the prefix is always valid (e.g. no path separators in it) when creating the temporary copy of the file in TezLocalCacheManager
> # Update tez local mode to behave the same way as mapreduce local mode in this scenario. Mapreduce local mode also doesn't support these types of links (links with a parent directory specified), but if it encounters them it is a soft failure (WARN log message) not a job failure.
>
> It is somewhat trickier to correctly support cache files linked with a nonexistent parent; if that feature is required it can be done as a separate JIRA.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)