You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/07/10 03:12:44 UTC
Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
Diffs
-----
src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67864/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205926
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65974, 65594, 65995, 65975, 65976, 65640, 67663, 67664, 67665, 67666, 67667, 67668, 67669, 67670, 67779, 67863, 67864]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 9, 2018, 8:12 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 9, 2018, 8:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205950
-----------------------------------------------------------
PASS: Mesos patch 67864 was successfully built and tested.
Reviews applied: `['65995', '65975', '65976', '65640', '67663', '67664', '67665', '67666', '67667', '67668', '67669', '67876', '67670', '67779', '67863', '67864']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1899/mesos-review-67864
- Mesos Reviewbot Windows
On July 10, 2018, 9:15 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 9:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205998
-----------------------------------------------------------
PASS: Mesos patch 67864 was successfully built and tested.
Reviews applied: `['65995', '65975', '65976', '65640', '67663', '67664', '67665', '67666', '67667', '67668', '67669', '67876', '67670', '67779', '67863', '67892', '67864']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1906/mesos-review-67864
- Mesos Reviewbot Windows
On July 12, 2018, 4:57 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 4:57 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp 728fb4c38c17c98b6c2a85447d3f32519c035e56
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review206049
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_validation_tests.cpp
Line 1913 (original), 1852 (patched)
<https://reviews.apache.org/r/67864/#comment289011>
s/target/source/, s/MOUTN/MOUNT/
This should have resulted in a test failure, right? If not, the string in the returned error has to be fixed as well :)
src/tests/master_validation_tests.cpp
Line 1921 (original), 1860 (patched)
<https://reviews.apache.org/r/67864/#comment289012>
s/target/source/
- Jan Schlicht
On July 12, 2018, 6:57 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 6:57 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp 728fb4c38c17c98b6c2a85447d3f32519c035e56
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review206074
-----------------------------------------------------------
PASS: Mesos patch 67864 was successfully built and tested.
Reviews applied: `['65995', '65975', '65976', '65640', '67663', '67664', '67665', '67666', '67667', '67668', '67669', '67876', '67670', '67779', '67863', '67892', '67864']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1921/mesos-review-67864
- Mesos Reviewbot Windows
On July 13, 2018, 11:29 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 11:29 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp 728fb4c38c17c98b6c2a85447d3f32519c035e56
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/4/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/
-----------------------------------------------------------
(Updated July 13, 2018, 6:29 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Jan's comments.
Bugs: MESOS-9066
https://issues.apache.org/jira/browse/MESOS-9066
Repository: mesos
Description
-------
Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
Diffs (updated)
-----
src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
src/tests/api_tests.cpp 728fb4c38c17c98b6c2a85447d3f32519c035e56
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67864/diff/4/
Changes: https://reviews.apache.org/r/67864/diff/3-4/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/
-----------------------------------------------------------
(Updated July 12, 2018, 4:57 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Addressed Jan's comment.
Bugs: MESOS-9066
https://issues.apache.org/jira/browse/MESOS-9066
Repository: mesos
Description
-------
Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
Diffs (updated)
-----
src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
src/tests/api_tests.cpp 728fb4c38c17c98b6c2a85447d3f32519c035e56
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67864/diff/3/
Changes: https://reviews.apache.org/r/67864/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On July 11, 2018, 2:24 p.m., Jan Schlicht wrote:
> > src/tests/mesos.hpp
> > Lines 1423 (patched)
> > <https://reviews.apache.org/r/67864/diff/2/?file=2058393#file2058393line1423>
> >
> > This isn't used, why introduce it here?
Just for consistency. I could remove this as well.
> On July 11, 2018, 2:24 p.m., Jan Schlicht wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 1107-1125 (original), 1107-1126 (patched)
> > <https://reviews.apache.org/r/67864/diff/2/?file=2058397#file2058397line1107>
> >
> > Nit: Why change this from creating a `BLOCK` to creating a `MOUNT`?
I probably used `BLOCK` before just to shorten the test a bit (since we don't need to specify the target type).
And I made the change here just to use a type that is well supported in Mesos.
But it actually doesn't matter at all lol. The code this test covers is basically the same.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205968
-----------------------------------------------------------
On July 10, 2018, 9:15 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 9:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205968
-----------------------------------------------------------
src/tests/mesos.hpp
Lines 1423 (patched)
<https://reviews.apache.org/r/67864/#comment288908>
This isn't used, why introduce it here?
src/tests/resource_provider_manager_tests.cpp
Lines 1107-1125 (original), 1107-1126 (patched)
<https://reviews.apache.org/r/67864/#comment288907>
Nit: Why change this from creating a `BLOCK` to creating a `MOUNT`?
- Jan Schlicht
On July 10, 2018, 11:15 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/
-----------------------------------------------------------
(Updated July 10, 2018, 9:15 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-9066
https://issues.apache.org/jira/browse/MESOS-9066
Repository: mesos
Description
-------
Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
Diffs (updated)
-----
src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
Diff: https://reviews.apache.org/r/67864/diff/2/
Changes: https://reviews.apache.org/r/67864/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and
`DESTROY_DISK` operations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205889
-----------------------------------------------------------
PASS: Mesos patch 67864 was successfully built and tested.
Reviews applied: `['65995', '65975', '65976', '65640', '67663', '67664', '67665', '67666', '67667', '67668', '67669', '67670', '67779', '67863', '67864']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1891/mesos-review-67864
- Mesos Reviewbot Windows
On July 10, 2018, 3:12 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> -----------------------------------------------------------
>
> (Updated July 10, 2018, 3:12 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
>
>
> Diffs
> -----
>
> src/examples/test_csi_user_framework.cpp 91212e990af711633f7b890b0c9e10587f9efe7c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
> src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb
> src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd
> src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe
> src/tests/operation_reconciliation_tests.cpp d0bc73bfbf304833cebb76c538cb2c5552813838
> src/tests/persistent_volume_tests.cpp 43f31b2e613666a989c205b8543ef1cde484d93c
> src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6
> src/tests/resource_provider_manager_tests.cpp cf15e5a1f26f0895865b53931298f61ce5cfccff
> src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5
>
>
> Diff: https://reviews.apache.org/r/67864/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>