You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/27 08:57:51 UTC
Review Request 26113: Upgrade to gradle 2.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26113/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
www.gradle.org/docs/2.1/release-notes.html
www.gradle.org/docs/2.0/release-notes.html
Distillation of major features that might help us:
2.1:
- Easier use of community plugins
- Incremental Java compilation
- Use of HTTPS for mavenCentral() and jcenter() dependency repositories
- PMD Console Output
2.0:
- Support for Java 8
Diffs
-----
build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6
gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba
gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a
src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702
src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa
Diff: https://reviews.apache.org/r/26113/diff/
Testing
-------
git clean -fdx
./gradlew build -Pq
Thanks,
Bill Farner
Re: Review Request 26113: Upgrade to gradle 2.1
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 29, 2014, 9:46 p.m., Kevin Sweeney wrote:
> > build.gradle, line 58
> > <https://reviews.apache.org/r/26113/diff/1/?file=707643#file707643line58>
> >
> > I think since this is groovy you can do it.name != 'compileGeneratedJava' instead?
Fixed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26113/#review54889
-----------------------------------------------------------
On Sept. 27, 2014, 6:57 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26113/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2014, 6:57 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> www.gradle.org/docs/2.1/release-notes.html
> www.gradle.org/docs/2.0/release-notes.html
>
> Distillation of major features that might help us:
>
> 2.1:
> - Easier use of community plugins
> - Incremental Java compilation
> - Use of HTTPS for mavenCentral() and jcenter() dependency repositories
> - PMD Console Output
>
> 2.0:
> - Support for Java 8
>
>
> Diffs
> -----
>
> build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6
> gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba
> gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a
> src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa
>
> Diff: https://reviews.apache.org/r/26113/diff/
>
>
> Testing
> -------
>
> git clean -fdx
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26113: Upgrade to gradle 2.1
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26113/#review54889
-----------------------------------------------------------
Ship it!
build.gradle
<https://reviews.apache.org/r/26113/#comment95220>
I think since this is groovy you can do it.name != 'compileGeneratedJava' instead?
- Kevin Sweeney
On Sept. 26, 2014, 11:57 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26113/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 11:57 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> www.gradle.org/docs/2.1/release-notes.html
> www.gradle.org/docs/2.0/release-notes.html
>
> Distillation of major features that might help us:
>
> 2.1:
> - Easier use of community plugins
> - Incremental Java compilation
> - Use of HTTPS for mavenCentral() and jcenter() dependency repositories
> - PMD Console Output
>
> 2.0:
> - Support for Java 8
>
>
> Diffs
> -----
>
> build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6
> gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba
> gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a
> src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa
>
> Diff: https://reviews.apache.org/r/26113/diff/
>
>
> Testing
> -------
>
> git clean -fdx
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 26113: Upgrade to gradle 2.1
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26113/
-----------------------------------------------------------
(Updated Sept. 29, 2014, 10:33 p.m.)
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
www.gradle.org/docs/2.1/release-notes.html
www.gradle.org/docs/2.0/release-notes.html
Distillation of major features that might help us:
2.1:
- Easier use of community plugins
- Incremental Java compilation
- Use of HTTPS for mavenCentral() and jcenter() dependency repositories
- PMD Console Output
2.0:
- Support for Java 8
Diffs (updated)
-----
build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6
gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba
gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a
src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702
src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa
Diff: https://reviews.apache.org/r/26113/diff/
Testing
-------
git clean -fdx
./gradlew build -Pq
Thanks,
Bill Farner