You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/06/08 07:01:03 UTC

Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1604
    https://issues.apache.org/jira/browse/RANGER-1604


Repository: ranger


Description
-------

DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
1. Add description information to configuration file to remind users don't use db to store audit log..
2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.


Diffs
-----

  security-admin/scripts/install.properties 06a1b89 
  security-admin/scripts/setup.sh ef61e8d 


Diff: https://reviews.apache.org/r/59908/diff/1/


Testing
-------


Thanks,

Qiang Zhang

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Qiang Zhang <zh...@zte.com.cn>.

> On 六月 8, 2017, 10:05 a.m., Colm O hEigeartaigh wrote:
> > "Currently it only support solr" - isn't hdfs supported as well here?
> 
> Qiang Zhang wrote:
>     The Ranger Admin uses the configuration item to determine log should be queried from db or solr. It only supported query logs from db or solr using Ranger Admin UI. Isn't hdfs supported as well here.

The hdfs isn't supported here.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/#review177291
-----------------------------------------------------------


On 六月 8, 2017, 7:05 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59908/
> -----------------------------------------------------------
> 
> (Updated 六月 8, 2017, 7:05 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1604
>     https://issues.apache.org/jira/browse/RANGER-1604
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
> 1. Add description information to configuration file to remind users don't use db to store audit log..
> 2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.
> 
> I carefully tested the issue.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/install.properties 06a1b89 
>   security-admin/scripts/setup.sh ef61e8d 
> 
> 
> Diff: https://reviews.apache.org/r/59908/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Qiang Zhang <zh...@zte.com.cn>.

> On June 8, 2017, 10:05 a.m., Colm O hEigeartaigh wrote:
> > "Currently it only support solr" - isn't hdfs supported as well here?
> 
> Qiang Zhang wrote:
>     The Ranger Admin uses the configuration item to determine log should be queried from db or solr. It only supported query logs from db or solr using Ranger Admin UI. Isn't hdfs supported as well here.
> 
> Qiang Zhang wrote:
>     The hdfs isn't supported here.
> 
> Colm O hEigeartaigh wrote:
>     OK thanks for the clarification. Maybe HDFS auditing is only supported for the plugins? In any case, please change "Currently it only support solr." to "Currently only solr is supported.".

Ok. I had fixed it.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/#review177291
-----------------------------------------------------------


On June 8, 2017, 7:05 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59908/
> -----------------------------------------------------------
> 
> (Updated June 8, 2017, 7:05 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1604
>     https://issues.apache.org/jira/browse/RANGER-1604
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
> 1. Add description information to configuration file to remind users don't use db to store audit log..
> 2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.
> 
> I carefully tested the issue.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/install.properties 06a1b89 
>   security-admin/scripts/setup.sh ef61e8d 
> 
> 
> Diff: https://reviews.apache.org/r/59908/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Colm O hEigeartaigh <co...@apache.org>.

> On June 8, 2017, 10:05 a.m., Colm O hEigeartaigh wrote:
> > "Currently it only support solr" - isn't hdfs supported as well here?
> 
> Qiang Zhang wrote:
>     The Ranger Admin uses the configuration item to determine log should be queried from db or solr. It only supported query logs from db or solr using Ranger Admin UI. Isn't hdfs supported as well here.
> 
> Qiang Zhang wrote:
>     The hdfs isn't supported here.

OK thanks for the clarification. Maybe HDFS auditing is only supported for the plugins? In any case, please change "Currently it only support solr." to "Currently only solr is supported.".


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/#review177291
-----------------------------------------------------------


On June 8, 2017, 7:05 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59908/
> -----------------------------------------------------------
> 
> (Updated June 8, 2017, 7:05 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1604
>     https://issues.apache.org/jira/browse/RANGER-1604
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
> 1. Add description information to configuration file to remind users don't use db to store audit log..
> 2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.
> 
> I carefully tested the issue.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/install.properties 06a1b89 
>   security-admin/scripts/setup.sh ef61e8d 
> 
> 
> Diff: https://reviews.apache.org/r/59908/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Qiang Zhang <zh...@zte.com.cn>.

> On 六月 8, 2017, 10:05 a.m., Colm O hEigeartaigh wrote:
> > "Currently it only support solr" - isn't hdfs supported as well here?

The Ranger Admin uses the configuration item to determine log should be queried from db or solr. It only supported query logs from db or solr using Ranger Admin UI. Isn't hdfs supported as well here.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/#review177291
-----------------------------------------------------------


On 六月 8, 2017, 7:05 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59908/
> -----------------------------------------------------------
> 
> (Updated 六月 8, 2017, 7:05 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1604
>     https://issues.apache.org/jira/browse/RANGER-1604
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
> 1. Add description information to configuration file to remind users don't use db to store audit log..
> 2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.
> 
> I carefully tested the issue.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/install.properties 06a1b89 
>   security-admin/scripts/setup.sh ef61e8d 
> 
> 
> Diff: https://reviews.apache.org/r/59908/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/#review177291
-----------------------------------------------------------



"Currently it only support solr" - isn't hdfs supported as well here?

- Colm O hEigeartaigh


On June 8, 2017, 7:05 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59908/
> -----------------------------------------------------------
> 
> (Updated June 8, 2017, 7:05 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1604
>     https://issues.apache.org/jira/browse/RANGER-1604
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
> 1. Add description information to configuration file to remind users don't use db to store audit log..
> 2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.
> 
> I carefully tested the issue.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/install.properties 06a1b89 
>   security-admin/scripts/setup.sh ef61e8d 
> 
> 
> Diff: https://reviews.apache.org/r/59908/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/#review177459
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On June 9, 2017, 9:45 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59908/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 9:45 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1604
>     https://issues.apache.org/jira/browse/RANGER-1604
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
> 1. Add description information to configuration file to remind users don't use db to store audit log..
> 2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.
> 
> I carefully tested the issue.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/install.properties 06a1b89 
>   security-admin/scripts/setup.sh ef61e8d 
> 
> 
> Diff: https://reviews.apache.org/r/59908/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/
-----------------------------------------------------------

(Updated June 9, 2017, 9:45 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1604
    https://issues.apache.org/jira/browse/RANGER-1604


Repository: ranger


Description
-------

DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
1. Add description information to configuration file to remind users don't use db to store audit log..
2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.

I carefully tested the issue.


Diffs (updated)
-----

  security-admin/scripts/install.properties 06a1b89 
  security-admin/scripts/setup.sh ef61e8d 


Diff: https://reviews.apache.org/r/59908/diff/2/

Changes: https://reviews.apache.org/r/59908/diff/1-2/


Testing
-------


Thanks,

Qiang Zhang

Re: Review Request 59908: DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286.

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59908/
-----------------------------------------------------------

(Updated June 8, 2017, 7:05 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1604
    https://issues.apache.org/jira/browse/RANGER-1604


Repository: ranger


Description (updated)
-------

DB based auditing had been removed in RANGER-900. But some configurations and codes are not removed accordingly in Ranger Admin. It often makes the user feel confused such as RANGER-1286. We should do the following modification:
1. Add description information to configuration file to remind users don't use db to store audit log..
2. Remove invalid code from setup.sh to eliminate misunderstanding. In order to avoid the introduction of the new issue, I do not modify db_setup.py and dba_script.py.

I carefully tested the issue.


Diffs
-----

  security-admin/scripts/install.properties 06a1b89 
  security-admin/scripts/setup.sh ef61e8d 


Diff: https://reviews.apache.org/r/59908/diff/1/


Testing
-------


Thanks,

Qiang Zhang