You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/30 09:23:56 UTC
[GitHub] [spark] 07ARB opened a new pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the
Fair Scheduler Pool Table
07ARB opened a new pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047
### What changes were proposed in this pull request?
Needs to improve the Column name and tooltips for the Fair Scheduler Pool Table.
### Why are the changes needed?
Need to correct SchedulingMode column name to -> 'Scheduling Mode' and tooltips need to add for Minimum Share, Pool Weight and Scheduling Mode (require meaning full Tool tips for the end user to understand.)
### Does this PR introduce any user-facing change?
YES
### How was this patch tested?
Manual Testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362009641
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
+ of CPU cores to allocate">Minimum Share</span>
+ </th>
+ <th>
+ <span title="This controls the pool's share of the cluster relative to other pools"
+ data-toggle="tooltip" data-placement="top">Pool Weight</span>
+ </th>
<th>Active Stages</th>
<th>Running Tasks</th>
- <th>SchedulingMode</th>
+ <th>
+ <span title="Mode to control whether jobs within the pool queue up behind each other
Review comment:
Not sure if we can meaningfully elaborate the mode here, maybe leave it.
Remember that any real docs would exist in the documentation, not here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362009205
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
Review comment:
These are a bit too long for tooltips. They are meant to elaborate, very briefly, the immediate meaning of the column. More like "Pool's minimum share of CPU cores"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the
Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569624741
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB edited a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB edited a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569899785
cc @zhengruifeng and @HyukjinKwon, please merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569899785
cc @zhengruifeng and @HyukjinKwon, please merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569633768
cc @gengliangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569732647
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20757/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569770930
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570304136
@07ARB Could you update the screenshot in the PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569772519
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569770930
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs
to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570460689
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570250829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20839/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs
to improve the Column name and tooltips for the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569626059
@srowen ,@cloud-fan and @HyukjinKwon please review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569734637
**[Test build #115966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115966/testReport)** for PR 27047 at commit [`2ac9cb1`](https://github.com/apache/spark/commit/2ac9cb1964597c8ab2ed6030cf08129306edb591).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570302787
**[Test build #116047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116047/testReport)** for PR 27047 at commit [`e52f85c`](https://github.com/apache/spark/commit/e52f85c10209f930d3530a4ba7808c353ce82284).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570250236
**[Test build #116047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116047/testReport)** for PR 27047 at commit [`e52f85c`](https://github.com/apache/spark/commit/e52f85c10209f930d3530a4ba7808c353ce82284).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569732224
**[Test build #115964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115964/testReport)** for PR 27047 at commit [`2ac9cb1`](https://github.com/apache/spark/commit/2ac9cb1964597c8ab2ed6030cf08129306edb591).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570247898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20838/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570464744
Thanks, merging to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569624741
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570303364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116047/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570250819
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570303357
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569772037
**[Test build #115964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115964/testReport)** for PR 27047 at commit [`2ac9cb1`](https://github.com/apache/spark/commit/2ac9cb1964597c8ab2ed6030cf08129306edb591).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570210044
**[Test build #4983 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4983/testReport)** for PR 27047 at commit [`e52f85c`](https://github.com/apache/spark/commit/e52f85c10209f930d3530a4ba7808c353ce82284).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570250236
**[Test build #116047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116047/testReport)** for PR 27047 at commit [`e52f85c`](https://github.com/apache/spark/commit/e52f85c10209f930d3530a4ba7808c353ce82284).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362030153
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
+ of CPU cores to allocate">Minimum Share</span>
+ </th>
+ <th>
+ <span title="This controls the pool's share of the cluster relative to other pools"
+ data-toggle="tooltip" data-placement="top">Pool Weight</span>
+ </th>
<th>Active Stages</th>
<th>Running Tasks</th>
- <th>SchedulingMode</th>
+ <th>
+ <span title="Mode to control whether jobs within the pool queue up behind each other
Review comment:
@srowen, this document i referred to construct tooptips https://spark.apache.org/docs/3.0.0-preview/job-scheduling.html , please check "Configuring Pool Properties" section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362009353
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
+ of CPU cores to allocate">Minimum Share</span>
+ </th>
+ <th>
+ <span title="This controls the pool's share of the cluster relative to other pools"
Review comment:
share of what? "Pool's share of cluster resources relative to others"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362025069
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
Review comment:
"Pool's minimum share of CPU cores" - This is fine, i will updated the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the
Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569624438
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569732632
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570247892
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs
to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569899785
@zhengruifeng , please merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569732224
**[Test build #115964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115964/testReport)** for PR 27047 at commit [`2ac9cb1`](https://github.com/apache/spark/commit/2ac9cb1964597c8ab2ed6030cf08129306edb591).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569772526
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115964/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570247898
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20838/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569770936
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115966/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27047: [SPARK-30384][WEBUI]Needs
to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569732115
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362026099
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
+ of CPU cores to allocate">Minimum Share</span>
+ </th>
+ <th>
+ <span title="This controls the pool's share of the cluster relative to other pools"
Review comment:
ok i will update the tooltips to this "Pool's share of cluster resources relative to others"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570250819
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569772519
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570303364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116047/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569772526
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115964/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362026420
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
+ of CPU cores to allocate">Minimum Share</span>
+ </th>
+ <th>
+ <span title="This controls the pool's share of the cluster relative to other pools"
+ data-toggle="tooltip" data-placement="top">Pool Weight</span>
+ </th>
<th>Active Stages</th>
<th>Running Tasks</th>
- <th>SchedulingMode</th>
+ <th>
+ <span title="Mode to control whether jobs within the pool queue up behind each other
Review comment:
ok i will remove the tooltips for mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362232307
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,17 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pool's minimum share of CPU
+ cores">Minimum Share</span>
+ </th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pool's share of cluster resources
+ relative to others pools">Pool Weight</span>
Review comment:
others pools -> others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27047: [SPARK-30384][WEBUI]Needs
to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570247666
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570250829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20839/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs
to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569911911
@HyukjinKwon and @zhengruifeng , can you please review this MR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569732647
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20757/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362026099
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,21 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pools can be set a minimum share
+ of CPU cores to allocate">Minimum Share</span>
+ </th>
+ <th>
+ <span title="This controls the pool's share of the cluster relative to other pools"
Review comment:
ok i will update the tooltips to this "Pool's share of cluster resources relative to others pools"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB edited a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB edited a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569911911
cc @srowen all tests passed.
Wish you a Happy New Year.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570246588
**[Test build #4983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4983/testReport)** for PR 27047 at commit [`e52f85c`](https://github.com/apache/spark/commit/e52f85c10209f930d3530a4ba7808c353ce82284).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570247892
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB commented on a change in pull request #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#discussion_r362288313
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/PoolTable.scala
##########
@@ -34,11 +34,17 @@ private[ui] class PoolTable(pools: Map[Schedulable, PoolData], parent: StagesTab
<table class="table table-bordered table-striped table-condensed sortable table-fixed">
<thead>
<th>Pool Name</th>
- <th>Minimum Share</th>
- <th>Pool Weight</th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pool's minimum share of CPU
+ cores">Minimum Share</span>
+ </th>
+ <th>
+ <span data-toggle="tooltip" data-placement="top" title="Pool's share of cluster resources
+ relative to others pools">Pool Weight</span>
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569732632
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570303357
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the
Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569624438
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569770936
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115966/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 07ARB edited a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
07ARB edited a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569911911
cc @srowen all tests passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-570210044
**[Test build #4983 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4983/testReport)** for PR 27047 at commit [`e52f85c`](https://github.com/apache/spark/commit/e52f85c10209f930d3530a4ba7808c353ce82284).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569770454
**[Test build #115966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115966/testReport)** for PR 27047 at commit [`2ac9cb1`](https://github.com/apache/spark/commit/2ac9cb1964597c8ab2ed6030cf08129306edb591).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27047:
[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for
the Fair Scheduler Pool Table
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27047: [SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table
URL: https://github.com/apache/spark/pull/27047#issuecomment-569734637
**[Test build #115966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115966/testReport)** for PR 27047 at commit [`2ac9cb1`](https://github.com/apache/spark/commit/2ac9cb1964597c8ab2ed6030cf08129306edb591).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org