[jira] [Commented] (HADOOP-15635) s3guard set-capacity command to fail fast if bucket is unguarded

["Gabor Bota (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582647#comment-16582647 ] 

Gabor Bota commented on HADOOP-15635:
-------------------------------------

Hi [~stevel@apache.org], I've started working on this, and found out it's not really clear what to check under org.apache.hadoop.fs.s3a.s3guard.S3GuardTool.SetCapacity to find out if s3guard is enabled. 
* is this an issue with the per-bucket setup?
* In your stacktrace you've provided the exception is thrown because the table does not exist AND {{fs.s3a.s3guard.ddb.table.create}} is false in the config. Should we check for this exception and write something more human-readable than the exception itself?
* Do we have a check right now to find out whether S3Guard is enabled for the bucket? According to my knowledge and the docs, S3Guard can be disabled if {{fs.s3a.metadatastore.impl}} set to {{org.apache.hadoop.fs.s3a.s3guard.NullMetadataStore}}. It would be an easy check in {{SetCapacity#run}} just to check for this.
* Another way to run S3GuardTool unguarded is to pass {{-unguarded}} argument. Do we need to handle this argument in SetCapacity? (imho it would not make sense to me to run this with {{-unguarded}})

I think we could check for the config if the implementation is {{org.apache.hadoop.fs.s3a.s3guard.NullMetadataStore}}, and then print an error message that you can not use this feature with NullMetadataStore. Do you agree?

> s3guard set-capacity command to fail fast if bucket is unguarded
> ----------------------------------------------------------------
>
>                 Key: HADOOP-15635
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15635
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.2.0
>            Reporter: Steve Loughran
>            Assignee: Gabor Bota
>            Priority: Minor
>
> If you try to do {{hadoop s3guard set-capacity s3a://landsat-pds}}, or any other bucket which exists but doesn't have s3guard enabled, you get a stack trace reporting that the ddb table doesn't exist.
> the command should check for the bucket being guarded and fail on that



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org