[GitHub] [helix] NealSun96 commented on pull request #1021: Add configurable thread pool size endpoints to Helix REST

[GitBox <gi...@apache.org>]

NealSun96 commented on pull request #1021:
URL: https://github.com/apache/helix/pull/1021#issuecomment-631797050


   After an offline discussion, we are temporarily suspending this PR. 
   We had the following concerns to the design: 
   1. Adding these endpoints seem to lead to an unscalable design, where for each config field, we provide endpoints. 
   2. We also have the option of adding hierarchy to the endpoints (such as "/task-framework/target-thread-pool-size"), but that requires other REST endpoints to comply with the same convention, which requires further discussion. 
   
   Since the design is up to debate, and these endpoints are not completely necessary, we are postponing the associated work to later. 
   
   Users can use "getInstanceConfig", "updateInstanceConfig", "getClusterConfig", "updateClusterConfig", and "getInstanceById" endpoints to achieve the desired functionalities. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org