You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/15 08:21:56 UTC

[GitHub] zeppelin pull request #2253: [ZEPPELIN-2179] Clear output DOES NOT work in p...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2253

    [ZEPPELIN-2179] Clear output DOES NOT work in personalized mode (master)

    ### What is this PR for?
    
    `clear output` (`cmd` + `opt` + `L`) doesn't work in the personalized mode.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2179](https://issues.apache.org/jira/browse/ZEPPELIN-2179)
    
    ### How should this be tested?
    
    1. Configure shiro
    2. Start Zeppelin and login in 2 browsers (e.g chrome and safari) with 2 different users (**DO NOT USE `dev` mode: localhost:9000**)
    3. Create a note
    4. Enable personalized mode
    5. Run paragraph and clear output in each browser
    
    ### Screenshots (if appropriate)
    
    NONE
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2179/clear-output-doesnt-work-in-person-mode-for-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2253
    
----
commit b7387849fe3b666c03de71e9ae7fb55902e6ecdf
Author: 1ambda <1a...@gmail.com>
Date:   2017-04-15T08:09:48Z

    fix: Clear output in personalized paragraph

commit eeff440ecdb2b4bc85a0c1c0113c69c85bfe8eb0
Author: 1ambda <1a...@gmail.com>
Date:   2017-04-15T08:18:56Z

    fix: Clear personalized output before running

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2253: [ZEPPELIN-2179] Clear output DOES NOT work in personal...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2253
  
    @jongyoul ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2253: [ZEPPELIN-2179] Clear output DOES NOT work in p...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2253


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2253: [ZEPPELIN-2179] Clear output DOES NOT work in personal...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2253
  
    @jongyoul Please help review this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2253: [ZEPPELIN-2179] Clear output DOES NOT work in personal...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2253
  
    @jongyul Please help review this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2253: [ZEPPELIN-2179] Clear output DOES NOT work in personal...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2253
  
    Tested. LGTM. will merge it into master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---