You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/01 14:21:58 UTC

[GitHub] [doris] starocean999 opened a new pull request, #15547: [Fix](Nereids)fix aggregation result error when child is empty relation

starocean999 opened a new pull request, #15547:
URL: https://github.com/apache/doris/pull/15547

   # Proposed changes
   this pr is follow up of https://github.com/apache/doris/pull/14964
   
   ## Problem summary
   consider the query bellow:
   
   _SELECT *
   FROM subquery1
   WHERE subquery1.k1 < 
       (SELECT max(aa)
       FROM 
           (SELECT k1 AS aa
           FROM subquery3
           WHERE subquery1.k2 = subquery3.v2) subquery3);_
   
   change agg function to nullable check if there is any group by exprs. The subquery unnesting will create a group by expr. So we have to move the subquery unnest rule before AdjustAggregateNullableForEmptySet rule
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morrySnow merged pull request #15547: [Fix](Nereids)fix aggregation result error when child is empty relation

Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #15547:
URL: https://github.com/apache/doris/pull/15547


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #15547: [Fix](Nereids)fix aggregation result error when child is empty relation

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15547:
URL: https://github.com/apache/doris/pull/15547#issuecomment-1368464807

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 36.49 seconds
    load time: 656 seconds
    storage size: 17123551530 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230101150533_clickbench_pr_72362.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15547: [Fix](Nereids)fix aggregation result error when child is empty relation

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15547:
URL: https://github.com/apache/doris/pull/15547#issuecomment-1369747617

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15547: [Fix](Nereids)fix aggregation result error when child is empty relation

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15547:
URL: https://github.com/apache/doris/pull/15547#issuecomment-1369747663

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org