You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/03/09 19:04:14 UTC
[GitHub] [drill] paul-rogers opened a new pull request #2017: DRILL-7632:
Improve user exception formatting
paul-rogers opened a new pull request #2017: DRILL-7632: Improve user exception formatting
URL: https://github.com/apache/drill/pull/2017
# [DRILL-7632](https://issues.apache.org/jira/browse/DRILL-7632): Improve user exception formatting
## Description
Modifies user exception to insert a colon between the "context" title and value. Old style:
```
My Context value
```
Revised:
```
My Context: value
```
Some code already added their own colons. So, the fix removes any existing colon before adding its own.
## Documentation
If the documentation shows exception output, and those exceptions contain context, then the format of that exception will change and such examples should be updated.
## Testing
Reran the full unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] asfgit closed pull request #2017: DRILL-7632: Improve user
exception formatting
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2017: DRILL-7632: Improve user exception formatting
URL: https://github.com/apache/drill/pull/2017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on issue #2017: DRILL-7632:
Improve user exception formatting
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #2017: DRILL-7632: Improve user exception formatting
URL: https://github.com/apache/drill/pull/2017#issuecomment-596994971
+1, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services