[GitHub] [ozone] ashishkumar50 commented on pull request #5293: HDDS-4368. SCM should avoid sending delete transactions for under-replicated containers

["ashishkumar50 (via GitHub)" <gi...@apache.org>]

ashishkumar50 commented on PR #5293:
URL: https://github.com/apache/ozone/pull/5293#issuecomment-1719381931

   [transactionToDNsCommitMap](https://github.com/apache/ozone/blob/742734b00603e9ce9aea24a231a594c0cbc56604/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java#L282) is kept in memory until response received from all the replicas. 
   I think, since it is just in memory when SCM restarts in under-replicated case it will again send request to all DN which may have already processed it, which is currently unnecessary.
   It may not look like it will slow down, Jira looks quite old so already some changes might have happened. Only thing map size will increase if more number of under-replicated containers are present and re-replication is getting delayed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org