You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/10/27 19:30:42 UTC
Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-3129
https://issues.apache.org/jira/browse/MESOS-3129
Repository: mesos
Description
-------
Relocate launcher and linux_launcher as MesosContainerizer specific
Diffs
-----
src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd
src/Makefile.am e797dac8093150871e9b68eba868f87df680ab43
src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
src/slave/containerizer/launcher.hpp
src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
src/slave/containerizer/linux_launcher.cpp c0adb34771fdb5a85d087296a8f98b890254ddf7
src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4
src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085
src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
src/tests/containerizer/isolator_tests.cpp 4e1e90ba2aeb70d4a70c3e0cf9796bd1aa199147
src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
src/tests/containerizer/port_mapping_tests.cpp ae2c0e613acf41614413e41e6989e9056328ff36
Diff: https://reviews.apache.org/r/39695/diff/
Testing
-------
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/#review104204
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39695]
All tests passed.
- Mesos ReviewBot
On Oct. 27, 2015, 6:30 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39695/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 6:30 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Relocate launcher and linux_launcher as MesosContainerizer specific
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd
> src/Makefile.am e797dac8093150871e9b68eba868f87df680ab43
> src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
> src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
> src/slave/containerizer/launcher.hpp
> src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
> src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
> src/slave/containerizer/linux_launcher.cpp c0adb34771fdb5a85d087296a8f98b890254ddf7
> src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4
> src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/isolator_tests.cpp 4e1e90ba2aeb70d4a70c3e0cf9796bd1aa199147
> src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
> src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
> src/tests/containerizer/port_mapping_tests.cpp ae2c0e613acf41614413e41e6989e9056328ff36
>
> Diff: https://reviews.apache.org/r/39695/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/#review104382
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39695]
All tests passed.
- Mesos ReviewBot
On Oct. 29, 2015, 12:11 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39695/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 12:11 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Relocate launcher and linux_launcher as MesosContainerizer specific
>
>
> Diffs
> -----
>
> src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
> src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
> src/slave/containerizer/launcher.hpp
> src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
> src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
> src/slave/containerizer/linux_launcher.cpp c0adb34771fdb5a85d087296a8f98b890254ddf7
> src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4
> src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/isolator_tests.cpp 4e1e90ba2aeb70d4a70c3e0cf9796bd1aa199147
> src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
> src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
> src/tests/containerizer/port_mapping_tests.cpp ae2c0e613acf41614413e41e6989e9056328ff36
>
> Diff: https://reviews.apache.org/r/39695/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/#review106124
-----------------------------------------------------------
src/CMakeLists.txt (lines 198 - 199)
<https://reviews.apache.org/r/39695/#comment164828>
Please move this up right below slave/containerizer/mesos/containerizer.cpp
src/Makefile.am (lines 548 - 549)
<https://reviews.apache.org/r/39695/#comment164827>
Please move this up right after 'slave/containerizer/mesos/containerizer.cpp'
src/slave/containerizer/containerizer.cpp (lines 37 - 39)
<https://reviews.apache.org/r/39695/#comment164826>
Please move this down.
src/slave/containerizer/containerizer.cpp (lines 44 - 46)
<https://reviews.apache.org/r/39695/#comment164825>
Please group them together and sort them accordingly.
src/slave/containerizer/external_containerizer.hpp (line 37)
<https://reviews.apache.org/r/39695/#comment164824>
Add a new line above.
src/slave/containerizer/mesos/containerizer.hpp (line 35)
<https://reviews.apache.org/r/39695/#comment164823>
Add a new line above.
src/slave/containerizer/mesos/containerizer.cpp (line 45)
<https://reviews.apache.org/r/39695/#comment164821>
Add a new line above.
src/tests/containerizer/mesos_containerizer_tests.cpp (lines 39 - 41)
<https://reviews.apache.org/r/39695/#comment164820>
Please group them together and sort them accordingly.
src/tests/containerizer/port_mapping_tests.cpp (lines 62 - 66)
<https://reviews.apache.org/r/39695/#comment164819>
Please group them together and sort them in alphebet order.
- Jie Yu
On Oct. 29, 2015, 12:11 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39695/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 12:11 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Relocate launcher and linux_launcher as MesosContainerizer specific
>
>
> Diffs
> -----
>
> src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
> src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
> src/slave/containerizer/launcher.hpp
> src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
> src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
> src/slave/containerizer/linux_launcher.cpp c0adb34771fdb5a85d087296a8f98b890254ddf7
> src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4
> src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085
> src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
> src/tests/containerizer/isolator_tests.cpp 4e1e90ba2aeb70d4a70c3e0cf9796bd1aa199147
> src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
> src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
> src/tests/containerizer/port_mapping_tests.cpp ae2c0e613acf41614413e41e6989e9056328ff36
>
> Diff: https://reviews.apache.org/r/39695/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/#review106167
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 11, 2015, 10:55 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39695/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 10:55 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Relocate launcher and linux_launcher as MesosContainerizer specific
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 7be464e5780dee2247c1c67f0dbcb25b1c4c0616
> src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f
> src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
> src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
> src/slave/containerizer/launcher.hpp
> src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
> src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
> src/slave/containerizer/linux_launcher.cpp ea76894127b8acb20ccf8fba38e4134fe5da27e8
> src/slave/containerizer/mesos/containerizer.hpp 3d134cadebbb5a9eb1724d5592921aff33a55e70
> src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4
> src/tests/containerizer/filesystem_isolator_tests.cpp 70320957637bc5305bf129ac50b33dd66e3773e1
> src/tests/containerizer/isolator_tests.cpp 25dbd547390f6017624b0cd35c91c1ee5c023c73
> src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
> src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
> src/tests/containerizer/port_mapping_tests.cpp 520e6b97e6bd34a03c850502647eb6de9a31795e
>
> Diff: https://reviews.apache.org/r/39695/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/#review106169
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39695]
All tests passed.
- Mesos ReviewBot
On Nov. 11, 2015, 10:55 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39695/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 10:55 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-3129
> https://issues.apache.org/jira/browse/MESOS-3129
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Relocate launcher and linux_launcher as MesosContainerizer specific
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 7be464e5780dee2247c1c67f0dbcb25b1c4c0616
> src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f
> src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
> src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
> src/slave/containerizer/launcher.hpp
> src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
> src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
> src/slave/containerizer/linux_launcher.cpp ea76894127b8acb20ccf8fba38e4134fe5da27e8
> src/slave/containerizer/mesos/containerizer.hpp 3d134cadebbb5a9eb1724d5592921aff33a55e70
> src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4
> src/tests/containerizer/filesystem_isolator_tests.cpp 70320957637bc5305bf129ac50b33dd66e3773e1
> src/tests/containerizer/isolator_tests.cpp 25dbd547390f6017624b0cd35c91c1ee5c023c73
> src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
> src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
> src/tests/containerizer/port_mapping_tests.cpp 520e6b97e6bd34a03c850502647eb6de9a31795e
>
> Diff: https://reviews.apache.org/r/39695/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/
-----------------------------------------------------------
(Updated Nov. 11, 2015, 2:55 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-3129
https://issues.apache.org/jira/browse/MESOS-3129
Repository: mesos
Description
-------
Relocate launcher and linux_launcher as MesosContainerizer specific
Diffs (updated)
-----
src/CMakeLists.txt 7be464e5780dee2247c1c67f0dbcb25b1c4c0616
src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f
src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
src/slave/containerizer/launcher.hpp
src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
src/slave/containerizer/linux_launcher.cpp ea76894127b8acb20ccf8fba38e4134fe5da27e8
src/slave/containerizer/mesos/containerizer.hpp 3d134cadebbb5a9eb1724d5592921aff33a55e70
src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4
src/tests/containerizer/filesystem_isolator_tests.cpp 70320957637bc5305bf129ac50b33dd66e3773e1
src/tests/containerizer/isolator_tests.cpp 25dbd547390f6017624b0cd35c91c1ee5c023c73
src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
src/tests/containerizer/port_mapping_tests.cpp 520e6b97e6bd34a03c850502647eb6de9a31795e
Diff: https://reviews.apache.org/r/39695/diff/
Testing
-------
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 39695: Relocate launcher and linux_launcher as
MesosContainerizer specific
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39695/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 5:11 p.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-3129
https://issues.apache.org/jira/browse/MESOS-3129
Repository: mesos
Description
-------
Relocate launcher and linux_launcher as MesosContainerizer specific
Diffs (updated)
-----
src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289
src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
src/slave/containerizer/containerizer.cpp 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
src/slave/containerizer/external_containerizer.hpp c00cebb93c5395bccbef558632d8f9c9bee8fffa
src/slave/containerizer/launcher.hpp
src/slave/containerizer/launcher.cpp 668ae80d0723068f85f7c16e0cc57804bb55af16
src/slave/containerizer/linux_launcher.hpp 627df892728f127f37672991e1a57ee445008fe1
src/slave/containerizer/linux_launcher.cpp c0adb34771fdb5a85d087296a8f98b890254ddf7
src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4
src/slave/containerizer/mesos/containerizer.cpp 91e4ea3a907ad165c359e7422135138737e14085
src/tests/containerizer/filesystem_isolator_tests.cpp 39008f6201777783d242407fea5377bfceffc57b
src/tests/containerizer/isolator_tests.cpp 4e1e90ba2aeb70d4a70c3e0cf9796bd1aa199147
src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180
src/tests/containerizer/mesos_containerizer_tests.cpp b48133c3d0624b27bcdc2289669c7f0b1bcc12f4
src/tests/containerizer/port_mapping_tests.cpp ae2c0e613acf41614413e41e6989e9056328ff36
Diff: https://reviews.apache.org/r/39695/diff/
Testing
-------
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song