[GitHub] [hudi] codope commented on a diff in pull request #9278: [HUDI-6312] Rename enum values of `HollowCommitHandling`

["codope (via GitHub)" <gi...@apache.org>]

codope commented on code in PR #9278:
URL: https://github.com/apache/hudi/pull/9278#discussion_r1285343004


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieCommonConfig.java:
##########
@@ -78,18 +78,18 @@ public class HoodieCommonConfig extends HoodieConfig {
 
   public static final ConfigProperty<String> INCREMENTAL_READ_HANDLE_HOLLOW_COMMIT = ConfigProperty
       .key("hoodie.datasource.read.handle.hollow.commit")
-      .defaultValue(HollowCommitHandling.EXCEPTION.name())
+      .defaultValue(HollowCommitHandling.FAIL.name())

Review Comment:
   @xushiyan @nsivabalan How about `hoodie.read.timeline.holes.resolution.strategy`? This can apply to both sql and datasource, plus timeline can have holes irrespective if concurrent writes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org