You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/07/29 12:35:30 UTC

[GitHub] zeppelin pull request #1246: [MINOR] Fix missing validation on interpreter p...

GitHub user r-kamath opened a pull request:

    https://github.com/apache/zeppelin/pull/1246

    [MINOR] Fix missing validation on interpreter page

    ### What is this PR for?
    Fix missing validation on interpreter page. TypeError on console when Save interpreter settings button is clicked without specifying any value.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    n/a
    
    ### How should this be tested?
    1) go to interpreter settings page and click on create buttons
    2) click on save without filling any fields
    
    ### Screenshots (if appropriate)
    before fix
    <img width="666" alt="screen shot 2016-07-29 at 5 26 28 pm" src="https://cloud.githubusercontent.com/assets/2031306/17248223/c3b7a194-55b6-11e6-9746-5d912a723f6a.png">
    
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/zeppelin interpreterPageFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1246
    
----
commit 0ccf5156123569c3c93562a354ae751c3e6cf15d
Author: Renjith Kamath <re...@gmail.com>
Date:   2016-07-29T12:30:55Z

    Fix missing validation on interpreter page

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1246: [MINOR] Fix missing validation on interpreter page

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1246
  
    CI failure is unrelated, Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1246: [MINOR] Fix missing validation on interpreter p...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1246: [MINOR] Fix missing validation on interpreter page

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1246
  
    Good catch, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---