You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:22:38 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
gaoyunhaii opened a new pull request #13249:
URL: https://github.com/apache/flink/pull/13249
## What is the purpose of the change
This PR tries to fix the case that when multiple consumer operators are connected to the same partitioner node, the partitioner would be shared for these consumer operators, thus cause data distributed wrongly.
To avoid this issue, we always clone the `StreamPartitioner` when creating the `StreamGraph` with the Java internal serializer. The clone would always success since it is also required to deploy the `StreamGraph` to TaskManagers.
## Brief change log
- ab39f750b7939b089626da89bd21a29e17d98cc3 clones the `StreamPartitioner` for each `StreamEdge`.
## Verifying this change
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
- This change is tested with UT.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r481325673
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1180,6 +1181,14 @@ public final CloseableRegistry getCancelables() {
}
}
+ // Clones the partition to avoid multiple stream edges sharing the same stream partitioner,
+ // like the case of https://issues.apache.org/jira/browse/FLINK-14087.
+ try {
+ outputPartitioner = InstantiationUtil.clone(outputPartitioner, Thread.currentThread().getContextClassLoader());
Review comment:
Very thanks! I agree with you that we should clone the partitioner before configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-682373957
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680766798
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ab39f750b7939b089626da89bd21a29e17d98cc3 (Wed Aug 26 09:24:47 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r477261178
##########
File path: flink-tests/src/test/java/org/apache/flink/test/streaming/api/datastream/DataStreamWithSharePartitionNodeTest.java
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.test.streaming.api.datastream;
+
+import org.apache.flink.api.common.functions.Partitioner;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.RichSinkFunction;
+import org.apache.flink.test.util.MiniClusterWithClientResource;
+import org.junit.ClassRule;
+import org.junit.Test;
+
+import javax.annotation.concurrent.GuardedBy;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * This tests verifies the data could be partitioned correctly
+ * if multiple consumers are connected to the same partitioner
+ * node.
+ */
+public class DataStreamWithSharePartitionNodeTest {
Review comment:
Also agree with that this should be an ITCase instead, I renamed the test accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 07e11ae0c700a4172a854ae4fd108b483bde6003 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888)
* 4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r481031562
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1180,6 +1181,14 @@ public final CloseableRegistry getCancelables() {
}
}
+ // Clones the partition to avoid multiple stream edges sharing the same stream partitioner,
+ // like the case of https://issues.apache.org/jira/browse/FLINK-14087.
+ try {
+ outputPartitioner = InstantiationUtil.clone(outputPartitioner, Thread.currentThread().getContextClassLoader());
Review comment:
In my opinion we should clone the partitioner before configuring it. I think the `configure` can theoretically initialize some state that is not serializable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-681625841
From the failed tests, the current implementation has some problems in that the `StreamGraph` is using `AppClassLoader`, which could not load the classes in the users' code. Besides, in Client side the ThreadContextLoader is not set with the `userClassLoader` currently, therefore it would be not easy to fix this problem with the current implementation.
There would be two possible solutions now:
1. In the client side we also set the userClassLoader as the Thread Context ClassLoader, but I'm not very sure if it is right to do so, and it seems to involves a lot.
2. As an alternative, we might postpone the `clone` till when we are going to create a `RecordWriter` at the `TaskManager` side. Currently TaskManager side has already set the Thread Context ClassLoader to be the userClassLoader.
I would first try the second method to see if the current issue could be solved separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-686532470
Thanks for the fix @gaoyunhaii
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8163b648a532556d5dcac7a13628fd2ac0843b79 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r481031562
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1180,6 +1181,14 @@ public final CloseableRegistry getCancelables() {
}
}
+ // Clones the partition to avoid multiple stream edges sharing the same stream partitioner,
+ // like the case of https://issues.apache.org/jira/browse/FLINK-14087.
+ try {
+ outputPartitioner = InstantiationUtil.clone(outputPartitioner, Thread.currentThread().getContextClassLoader());
Review comment:
In my opinion we should clone the partitioner before initializing it. I think the `configure` can theoretically initialize some state that is not serializable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab39f750b7939b089626da89bd21a29e17d98cc3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881)
* 8163b648a532556d5dcac7a13628fd2ac0843b79 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ab39f750b7939b089626da89bd21a29e17d98cc3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069",
"triggerID" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07e11ae0c700a4172a854ae4fd108b483bde6003 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947)
* dac56bd078915f2b86835cf5e8cdba3233ee834f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069",
"triggerID" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"triggerType" : "PUSH"
}, {
"hash" : "89525a7780799d6acf2227b229e357c26fc353e2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6138",
"triggerID" : "89525a7780799d6acf2227b229e357c26fc353e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dac56bd078915f2b86835cf5e8cdba3233ee834f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069)
* 89525a7780799d6acf2227b229e357c26fc353e2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6138)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-681625841
From the failed tests, the current implementation has some problems in that the `StreamGraph` is using `AppClassLoader`, which could not load the classes in the users' code. Besides, in Client side the ThreadContextLoader is not set with the `userClassLoader` currently, therefore it would be not easy to fix this problem with the current implementation.
There would be two possible solutions now:
1. In the client side we also set the userClassLoader as the Thread Context ClassLoader, but I'm not very sure if it is right to do so, and it seems to involves a lot.
2. As an alternative, we might postpone the `clone` till when we are going to create a `RecordWriter` at the `TaskManager` side.
I would first try the second method to see if the current issue could be solved separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 07e11ae0c700a4172a854ae4fd108b483bde6003 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 07e11ae0c700a4172a854ae4fd108b483bde6003 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07e11ae0c700a4172a854ae4fd108b483bde6003 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947)
* dac56bd078915f2b86835cf5e8cdba3233ee834f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8163b648a532556d5dcac7a13628fd2ac0843b79 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883)
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-681056131
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069",
"triggerID" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"triggerType" : "PUSH"
}, {
"hash" : "89525a7780799d6acf2227b229e357c26fc353e2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6138",
"triggerID" : "89525a7780799d6acf2227b229e357c26fc353e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89525a7780799d6acf2227b229e357c26fc353e2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6138)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r481928736
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1160,14 +1160,25 @@ public final CloseableRegistry getCancelables() {
return recordWriters;
}
+ @SuppressWarnings("unchecked")
private static <OUT> RecordWriter<SerializationDelegate<StreamRecord<OUT>>> createRecordWriter(
StreamEdge edge,
int outputIndex,
Environment environment,
String taskName,
long bufferTimeout) {
- @SuppressWarnings("unchecked")
- StreamPartitioner<OUT> outputPartitioner = (StreamPartitioner<OUT>) edge.getPartitioner();
+
+ StreamPartitioner<OUT> outputPartitioner = null;
+
+ // Clones the partition to avoid multiple stream edges sharing the same stream partitioner,
+ // like the case of https://issues.apache.org/jira/browse/FLINK-14087.
+ try {
+ outputPartitioner = InstantiationUtil.clone(
+ (StreamPartitioner<OUT>) edge.getPartitioner(),
+ Thread.currentThread().getContextClassLoader());
Review comment:
I am really sorry for yet another comment, but I've spotted it only now.
How about we use the `environment.getUserClassLoader()` instead of `Thread.currentThread().getContextClassLoader()`? I think it is safer that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915)
* 07e11ae0c700a4172a854ae4fd108b483bde6003 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r482747530
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1160,14 +1160,25 @@ public final CloseableRegistry getCancelables() {
return recordWriters;
}
+ @SuppressWarnings("unchecked")
private static <OUT> RecordWriter<SerializationDelegate<StreamRecord<OUT>>> createRecordWriter(
StreamEdge edge,
int outputIndex,
Environment environment,
String taskName,
long bufferTimeout) {
- @SuppressWarnings("unchecked")
- StreamPartitioner<OUT> outputPartitioner = (StreamPartitioner<OUT>) edge.getPartitioner();
+
+ StreamPartitioner<OUT> outputPartitioner = null;
+
+ // Clones the partition to avoid multiple stream edges sharing the same stream partitioner,
+ // like the case of https://issues.apache.org/jira/browse/FLINK-14087.
+ try {
+ outputPartitioner = InstantiationUtil.clone(
+ (StreamPartitioner<OUT>) edge.getPartitioner(),
+ Thread.currentThread().getContextClassLoader());
Review comment:
Very thanks Dawid! I also think that it would be much better that we get the user classloader in a more deterministic way. I have updated the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #13249:
URL: https://github.com/apache/flink/pull/13249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069",
"triggerID" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"triggerType" : "PUSH"
}, {
"hash" : "89525a7780799d6acf2227b229e357c26fc353e2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "89525a7780799d6acf2227b229e357c26fc353e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dac56bd078915f2b86835cf5e8cdba3233ee834f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069)
* 89525a7780799d6acf2227b229e357c26fc353e2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #13249:
URL: https://github.com/apache/flink/pull/13249#discussion_r477206706
##########
File path: flink-tests/src/test/java/org/apache/flink/test/streaming/api/datastream/DataStreamWithSharePartitionNodeTest.java
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.test.streaming.api.datastream;
+
+import org.apache.flink.api.common.functions.Partitioner;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.RichSinkFunction;
+import org.apache.flink.test.util.MiniClusterWithClientResource;
+import org.junit.ClassRule;
+import org.junit.Test;
+
+import javax.annotation.concurrent.GuardedBy;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * This tests verifies the data could be partitioned correctly
+ * if multiple consumers are connected to the same partitioner
+ * node.
+ */
+public class DataStreamWithSharePartitionNodeTest {
Review comment:
shall we name it `DataStreamWithSharedPartitionNodeITCase` ? I think it is an it test and should be executed with other IT tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07e11ae0c700a4172a854ae4fd108b483bde6003 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5958",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "682373957",
"triggerType" : "MANUAL"
}, {
"hash" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069",
"triggerID" : "dac56bd078915f2b86835cf5e8cdba3233ee834f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dac56bd078915f2b86835cf5e8cdba3233ee834f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8163b648a532556d5dcac7a13628fd2ac0843b79 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883)
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
}, {
"hash" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947",
"triggerID" : "07e11ae0c700a4172a854ae4fd108b483bde6003",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5915)
* 07e11ae0c700a4172a854ae4fd108b483bde6003 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5947)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13249: [FLINK-14087][datastream] Clone the StreamPartitioner to avoid being shared at runtime.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13249:
URL: https://github.com/apache/flink/pull/13249#issuecomment-680775587
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5881",
"triggerID" : "ab39f750b7939b089626da89bd21a29e17d98cc3",
"triggerType" : "PUSH"
}, {
"hash" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5883",
"triggerID" : "8163b648a532556d5dcac7a13628fd2ac0843b79",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"triggerType" : "PUSH"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "6e53b34cb612e02e808008a6792c16fb60ac64e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888",
"triggerID" : "681056131",
"triggerType" : "MANUAL"
}, {
"hash" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e53b34cb612e02e808008a6792c16fb60ac64e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5896) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5888)
* 4eae231a2cd3edbb2ba34f7bef983f64a4c4fefa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org