You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by LantaoJin <gi...@git.apache.org> on 2018/10/25 08:01:00 UTC
[GitHub] incubator-livy pull request #124: [LIVY-531][BUILD] Update spark-2.3 default...
GitHub user LantaoJin opened a pull request:
https://github.com/apache/incubator-livy/pull/124
[LIVY-531][BUILD] Update spark-2.3 default version to 2.3.2
## What changes were proposed in this pull request?
Due to spark 2.3.2 is highly recommended version to upgrade for all 2.3.x users which contains many stability bug fixes.
## How was this patch tested?
Existing UTs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/LantaoJin/incubator-livy LIVY-531
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-livy/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit 9532e802a1c567cbb2b0fd9eebcf88e7073f5295
Author: Lantao Jin <ji...@...>
Date: 2018-10-25T07:59:17Z
[LIVY-531][BUILD] Update spark 2.3 default version to 2.3.2
----
---
[GitHub] incubator-livy pull request #124: [LIVY-531][BUILD] Update spark-2.3 default...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-livy/pull/124
---
[GitHub] incubator-livy issue #124: [LIVY-531][BUILD] Update spark-2.3 default versio...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-livy/pull/124
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/124?src=pr&el=h1) Report
> Merging [#124](https://codecov.io/gh/apache/incubator-livy/pull/124?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/328425d05aa7b0b6acb5fc74000b1362f310f2c5?src=pr&el=desc) will **decrease** coverage by `0.5%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-livy/pull/124?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #124 +/- ##
============================================
- Coverage 71.2% 70.69% -0.51%
+ Complexity 923 920 -3
============================================
Files 100 100
Lines 5500 5500
Branches 828 828
============================================
- Hits 3916 3888 -28
- Misses 1049 1077 +28
Partials 535 535
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/124?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `71.12% <0%> (-8.46%)` | `33% <0%> (ø)` | |
| [...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjRGlzcGF0Y2hlci5qYXZh) | `63.26% <0%> (-4.09%)` | `19% <0%> (-1%)` | |
| [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `81.63% <0%> (-2.56%)` | `18% <0%> (ø)` | |
| [rsc/src/main/java/org/apache/livy/rsc/Utils.java](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9VdGlscy5qYXZh) | `85.36% <0%> (-2.44%)` | `16% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `76.69% <0%> (-2.12%)` | `39% <0%> (-1%)` | |
| [rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjLmphdmE=) | `79.28% <0%> (-0.6%)` | `12% <0%> (ø)` | |
| [.../scala/org/apache/livy/sessions/SessionState.scala](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvc2Vzc2lvbnMvU2Vzc2lvblN0YXRlLnNjYWxh) | `61.11% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: |
| [...in/java/org/apache/livy/rsc/driver/JobWrapper.java](https://codecov.io/gh/apache/incubator-livy/pull/124/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvSm9iV3JhcHBlci5qYXZh) | `80% <0%> (ø)` | `7% <0%> (-1%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/124?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/124?src=pr&el=footer). Last update [328425d...9532e80](https://codecov.io/gh/apache/incubator-livy/pull/124?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] incubator-livy issue #124: [LIVY-531][BUILD] Update spark-2.3 default versio...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/124
Livy doesn't ship with Spark, so in the end this doesn't make a whole lot of difference. But sure, let's test against the latest one at least.
Merging to master.
---
[GitHub] incubator-livy issue #124: [LIVY-531][BUILD] Update spark-2.3 default versio...
Posted by LantaoJin <gi...@git.apache.org>.
Github user LantaoJin commented on the issue:
https://github.com/apache/incubator-livy/pull/124
cc @jerryshao
---