You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/06 15:11:29 UTC
[GitHub] [dubbo-go] cityiron commented on a change in pull request #824: Ftr: Add grpc max message size config
cityiron commented on a change in pull request #824:
URL: https://github.com/apache/dubbo-go/pull/824#discussion_r518811640
##########
File path: config/service_config.go
##########
@@ -73,6 +73,7 @@ type ServiceConfig struct {
Auth string `yaml:"auth" json:"auth,omitempty" property:"auth"`
ParamSign string `yaml:"param.sign" json:"param.sign,omitempty" property:"param.sign"`
Tag string `yaml:"tag" json:"tag,omitempty" property:"tag"`
+ GrpcMaxMessageSize int `default:"4" yaml:"max_message_size" json:"max_message_size,omitempty"`
Review comment:
I think other field is common field name, but GrpcMaxMessageSize mean only for grpc, so in my view MaxMessageSize is better.
##########
File path: common/constant/key.go
##########
@@ -25,6 +25,7 @@ const (
GROUP_KEY = "group"
VERSION_KEY = "version"
INTERFACE_KEY = "interface"
+ GRPC_MESSAGE_SIZE_KEY = "message_size"
Review comment:
GRPC_MESSAGE_SIZE_KEY change to MESSAGE_SIZE_KEY may be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org