You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/04/03 22:17:57 UTC

[GitHub] wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error

wu-sheng commented on issue #1022: avoid "by zero" exception when all request are error
URL: https://github.com/apache/incubator-skywalking/pull/1022#issuecomment-378417329
 
 
   @peng-yongsheng if we intend to process error in tps and avg reponse time, I think there are three metrics
   1. calls and avg response time of all calls
   1. calls and avg responsr time of sucess calls
   1. calls and avg response timr of fail calls
   
   In current version, I prefer the 2). If you want more, I am OK. But I dont like change the metric meaning in different condition. If you want those, I suggest to add more metrics in query results. And discuss with @hanahmily to decide how to visualize them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services