[GitHub] [iceberg] danielcweeks commented on a change in pull request #1844: AWS: support custom client configuration

[GitBox <gi...@apache.org>]

danielcweeks commented on a change in pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#discussion_r535435417



##########
File path: api/src/main/java/org/apache/iceberg/io/FileIO.java
##########
@@ -20,7 +20,7 @@
 package org.apache.iceberg.io;
 
 import java.io.Serializable;
-import java.util.Map;
+import org.apache.iceberg.catalog.CatalogConfigurable;

Review comment:
       So, there are some features that we might want to control at the table level, but I think that's just going to complicate things.  @rdblue brought up a good point that table level properties are not available on initial load (only catalog properties), so we would need to thing through what cases would really benefit from table level overrides.  We can revisit that later, so I'll resolve.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org