You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/01 17:17:47 UTC
[GitHub] [beam] TheNeuralBit opened a new pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
TheNeuralBit opened a new pull request #12749:
URL: https://github.com/apache/beam/pull/12749
This PR splits out the uncontroversial portions of #12705, the elementwise methods.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------



See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.08%
==========================================
Files 451 454 +3
Lines 53169 53679 +510
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32085 +345
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.77% <0.00%> (-0.85%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.08% -0.22%
==========================================
Files 451 454 +3
Lines 53169 53982 +813
==========================================
+ Hits 21429 21638 +209
- Misses 31740 32344 +604
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (-0.63%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685913517
Looks like flake BEAM-10657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.08% -0.22%
==========================================
Files 451 454 +3
Lines 53169 53982 +813
==========================================
+ Hits 21429 21638 +209
- Misses 31740 32344 +604
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (-0.63%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.08%
==========================================
Files 451 454 +3
Lines 53169 53679 +510
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32085 +345
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.77% <0.00%> (-0.85%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/dc3144d54c1f2adcc4f71520d5c1468a4a48e735?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
=======================================
Coverage 40.22% 40.22%
=======================================
Files 454 454
Lines 53670 53687 +17
=======================================
+ Hits 21587 21594 +7
- Misses 32083 32093 +10
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.08%
==========================================
Files 451 454 +3
Lines 53169 53679 +510
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32085 +345
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.77% <0.00%> (-0.85%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...4b51fcc](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685166474
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12749:
URL: https://github.com/apache/beam/pull/12749#discussion_r481492101
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -200,6 +200,15 @@ def update(self, other):
view = frame_base.wont_implement_method('memory sharing semantics')
+ @property
+ def str(self):
+ expr = expressions.ComputedExpression(
+ 'str',
+ lambda df: df.str, [self._expr],
+ requires_partition_by=partitionings.Nothing(),
+ preserves_partition_by=partitionings.Nothing())
Review comment:
Doh yes this is basically an elementwise_method. Good catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.08%
==========================================
Files 451 454 +3
Lines 53169 53679 +510
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32085 +345
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.77% <0.00%> (-0.85%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.08%
==========================================
Files 451 454 +3
Lines 53169 53679 +510
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32085 +345
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.77% <0.00%> (-0.85%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.09%
==========================================
Files 451 454 +3
Lines 53169 53687 +518
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32093 +353
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-1.01%)` | :arrow_down: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.09%
==========================================
Files 451 454 +3
Lines 53169 53687 +518
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32093 +353
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-1.01%)` | :arrow_down: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/dc3144d54c1f2adcc4f71520d5c1468a4a48e735?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
=======================================
Coverage 40.22% 40.22%
=======================================
Files 454 454
Lines 53670 53687 +17
=======================================
+ Hits 21587 21594 +7
- Misses 32083 32093 +10
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685157473
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685119731
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685913271
Run Portable_Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685205583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.09%
==========================================
Files 451 454 +3
Lines 53169 53687 +518
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32093 +353
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-1.01%)` | :arrow_down: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/dc3144d54c1f2adcc4f71520d5c1468a4a48e735?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
=======================================
Coverage 40.22% 40.22%
=======================================
Files 454 454
Lines 53670 53687 +17
=======================================
+ Hits 21587 21594 +7
- Misses 32083 32093 +10
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-686581124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.08% -0.22%
==========================================
Files 451 454 +3
Lines 53169 53982 +813
==========================================
+ Hits 21429 21638 +209
- Misses 31740 32344 +604
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (-0.63%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.08% -0.22%
==========================================
Files 451 454 +3
Lines 53169 53982 +813
==========================================
+ Hits 21429 21638 +209
- Misses 31740 32344 +604
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (-0.63%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.09%
==========================================
Files 451 454 +3
Lines 53169 53687 +518
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32093 +353
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.62% <0.00%> (-1.01%)` | :arrow_down: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...316d842](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-686787859
Run Portable_Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.08%
==========================================
Files 451 454 +3
Lines 53169 53679 +510
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32085 +345
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.77% <0.00%> (-0.85%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...4b51fcc](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685913385
Run PythonDocker PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.22% -0.08%
==========================================
Files 451 454 +3
Lines 53169 53679 +510
==========================================
+ Hits 21429 21594 +165
- Misses 31740 32085 +345
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `13.77% <0.00%> (-0.85%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...4b51fcc](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a change in pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #12749:
URL: https://github.com/apache/beam/pull/12749#discussion_r481490737
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -200,6 +200,15 @@ def update(self, other):
view = frame_base.wont_implement_method('memory sharing semantics')
+ @property
+ def str(self):
+ expr = expressions.ComputedExpression(
+ 'str',
+ lambda df: df.str, [self._expr],
+ requires_partition_by=partitionings.Nothing(),
+ preserves_partition_by=partitionings.Nothing())
Review comment:
Doesn't it preserve all partitionings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685029230
# [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=h1) Report
> Merging [#12749](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/6bc39bc52f517000b9e8b59c56ede57d49e11ef3?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12749 +/- ##
==========================================
- Coverage 40.30% 40.08% -0.22%
==========================================
Files 451 454 +3
Lines 53169 53982 +813
==========================================
+ Hits 21429 21638 +209
- Misses 31740 32344 +604
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `43.73% <77.77%> (+0.76%)` | :arrow_up: |
| [...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==) | `29.60% <0.00%> (-0.98%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `14.00% <0.00%> (-0.63%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/filesystems.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZXN5c3RlbXMucHk=) | `57.50% <0.00%> (-0.26%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9lbnZpcm9ubWVudHMucHk=) | `52.42% <0.00%> (-0.18%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=footer). Last update [d89bbfa...e036863](https://codecov.io/gh/apache/beam/pull/12749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685011519
R: @ibzib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit edited a comment on pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit edited a comment on pull request #12749:
URL: https://github.com/apache/beam/pull/12749#issuecomment-685913517
Looks like flake BEAM-10567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #12749: [BEAM-10720] Add implementation for elementwise str methods
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #12749:
URL: https://github.com/apache/beam/pull/12749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org