[jira] [Commented] (TINKERPOP-2193) Allow a Traversal to know what TraversalSource it spawned from

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811388#comment-16811388 ] 

ASF GitHub Bot commented on TINKERPOP-2193:
-------------------------------------------

spmallette commented on pull request #1092: TINKERPOP-2193 Allow a Traversal to know what TraversalSource it spawned from
URL: https://github.com/apache/tinkerpop/pull/1092
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2193
   
   Unclear why this wasn't done originally. As noted in the JIRA we already had the `TraversalSource` passed to the created `Traversal` only to pick and choose bits/pieces we wanted to keep rather than the `TraversalSource` itself.  
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow a Traversal to know what TraversalSource it spawned from
> --------------------------------------------------------------
>
>                 Key: TINKERPOP-2193
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2193
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.4.1
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Major
>
> It's odd that a {{Traversal}} has no knowledge of the {{TraversalSource}} it spawned from. I say "odd" because:
> 1. we pass the {{TraversalSource}} to the {{Traversal}} on construction only to extract information from it and then throw it away
> 2. one of the data points we do grab is the {{Graph}} instance of the {{TraversalSource}} and for some reason we keep that around for the purpose of sometime spawning more {{TraversalSource}} instances in other components.
> I'm not sure if there was a reason for not keeping the {{TraversalSource}} at some point, but I'm going to add it and see what happens. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)