You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2019/09/06 12:51:00 UTC

[jira] [Resolved] (CALCITE-3322) There are two same testcase in RelMetadataTest

     [ https://issues.apache.org/jira/browse/CALCITE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stamatis Zampetakis resolved CALCITE-3322.
------------------------------------------
    Resolution: Fixed

Fixed in [faeb6d0ea16c493157a1159c49cb970790c10cc1|https://github.com/apache/calcite/commit/faeb6d0ea16c493157a1159c49cb970790c10cc1]. Thanks for the PR [~shenhong]!

> There are two same testcase in RelMetadataTest
> ----------------------------------------------
>
>                 Key: CALCITE-3322
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3322
>             Project: Calcite
>          Issue Type: Test
>          Components: core
>    Affects Versions: 1.20.0
>            Reporter: Hong Shen
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> When I read the code, I found two identical testcases in RelMetadataTest, except for the different names, which might need to be changed to limit 0, or just need to keep one.
> {code:java}
>   @Test public void testRowCountSortLimit() {
>     final String sql = "select * from emp order by ename limit 10";
>     checkRowCount(sql, 10d, 0D, 10d);
>   }
>   @Test public void testRowCountSortLimit0() {
>     final String sql = "select * from emp order by ename limit 10";
>     checkRowCount(sql, 10d, 0D, 10d);
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)