You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/28 08:12:00 UTC
[jira] [Commented] (AIRFLOW-3127) Celery SSL Documentation is
out-dated
[ https://issues.apache.org/jira/browse/AIRFLOW-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631510#comment-16631510 ]
ASF GitHub Bot commented on AIRFLOW-3127:
-----------------------------------------
XD-DENG opened a new pull request #3967: [AIRFLOW-3127] Fix out-dated doc for Celery SSL
URL: https://github.com/apache/incubator-airflow/pull/3967
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3127
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Now in `airflow.cfg`, for Celery-SSL, the item names are "**ssl_active**", "**ssl_key**", "**ssl_cert**", and "**ssl_cacert**" (since PR https://github.com/apache/incubator-airflow/pull/2806/files).
But in the documentation https://airflow.incubator.apache.org/security.html?highlight=celery#ssl
or https://github.com/apache/incubator-airflow/blob/master/docs/security.rst,
it's "**CELERY_SSL_ACTIVE**", "**CELERY_SSL_KEY**", "**CELERY_SSL_CERT**", and
"**CELERY_SSL_CACERT**", which is out-dated and may confuse readers.
**Screenshot of out-dated doc**
<img width="757" alt="screen shot 2018-09-28 at 4 09 18 pm" src="https://user-images.githubusercontent.com/11539188/46196186-e86f6700-c338-11e8-9e86-bca7126c5612.png">
(And fixed a minor typo in `docs/howto/set-config.rst`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Celery SSL Documentation is out-dated
> -------------------------------------
>
> Key: AIRFLOW-3127
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3127
> Project: Apache Airflow
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 1.10.0
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
>
> Now in `airflow.cfg`, for Celery-SSL, the items names are "ssl_active", "ssl_key", "ssl_cert", and "ssl_cacert". (since PR https://github.com/apache/incubator-airflow/pull/2806/files)
> But in the documentation [https://airflow.incubator.apache.org/security.html?highlight=celery]
> or
> [https://github.com/apache/incubator-airflow/blob/master/docs/security.rst,] it's "CELERY_SSL_ACTIVE", "CELERY_SSL_KEY", "CELERY_SSL_CERT", and
> "CELERY_SSL_CACERT", which is out-dated.
>
> This may confuse readers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)