You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/12/29 14:35:06 UTC

[PR] [docs] Add example for how to import the library [pulsar-client-cpp]

BewareMyPower opened a new pull request, #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [docs] Add example for how to import the library [pulsar-client-cpp]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [docs] Add example for how to import the library [pulsar-client-cpp]

Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on PR #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379#issuecomment-1907234515

   > @RobertIndie Have you fetched the submodule? Please note that this PR also updates the commit of the vcpkg submodule. Could you run the following command and show the output?
   > 
   > ```shell
   > cd vcpkg && git log --pretty=oneline | head -n 1
   > ```
   > 
   > If you only ran `git apply 379.diff`, maybe it won't work.
   
   Thanks. It works now! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [docs] Add example for how to import the library [pulsar-client-cpp]

Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on PR #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379#issuecomment-1903644297

   I am trying to run the example. But it throws the following errors when executing `cmake -B build`:
   ```
   -- Running vcpkg install
   pulsar-client-cpp does not exist
   -- Running vcpkg install - failed
   CMake Error at /Users/rbt/code/pulsar-client-cpp/vcpkg/scripts/buildsystems/vcpkg.cmake:899 (message):
     vcpkg install failed.  See logs for more information:
     /Users/rbt/code/pulsar-client-cpp/vcpkg-example/build/vcpkg-manifest-install.log
   Call Stack (most recent call first):
     /opt/homebrew/Cellar/cmake/3.28.1/share/cmake/Modules/CMakeDetermineSystem.cmake:170 (include)
     CMakeLists.txt:10 (project)
   
   CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
   CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
   -- Configuring incomplete, errors occurred!
   
   ```
   
   In `/Users/rbt/code/pulsar-client-cpp/vcpkg-example/build/vcpkg-manifest-install.log`:
   ```
   pulsar-client-cpp does not exist
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [docs] Add example for how to import the library [pulsar-client-cpp]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379#issuecomment-1903910358

   @RobertIndie Have you fetched the submodule? Please note that this PR also updates the commit of the vcpkg submodule. Could you run the following command and show the output?
   
   ```bash
   cd vcpkg && git log --pretty=oneline | head -n 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [docs] Add example for how to import the library [pulsar-client-cpp]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379#issuecomment-1872182679

   There is a fix needed in the upstream. When `CMAKE_BUILD_TYPE` is not defined, the release library and debug library could be the same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [docs] Add example for how to import the library [pulsar-client-cpp]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on code in PR #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379#discussion_r1461333687


##########
README.md:
##########
@@ -27,6 +27,16 @@ For the supported Pulsar features, see [Client Feature Matrix](https://pulsar.ap
 
 For how to use APIs to publish and consume messages, see [examples](https://github.com/apache/pulsar-client-cpp/tree/main/examples).
 
+## Import the library into your project
+
+### CMake with vcpkg integration
+
+Navigate to [vcpkg-example](./vcpkg-example) for how to import the `pulsar-client-cpp` into your project via vcpkg.
+
+### Download pre-built binaries
+
+For non-vcpkg projects, you can download pre-built binaries from the [official release page](https://pulsar.apache.org/download/#pulsar-c-client).

Review Comment:
   Yes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [docs] Add example for how to import the library [pulsar-client-cpp]

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on code in PR #379:
URL: https://github.com/apache/pulsar-client-cpp/pull/379#discussion_r1461312881


##########
README.md:
##########
@@ -27,6 +27,16 @@ For the supported Pulsar features, see [Client Feature Matrix](https://pulsar.ap
 
 For how to use APIs to publish and consume messages, see [examples](https://github.com/apache/pulsar-client-cpp/tree/main/examples).
 
+## Import the library into your project
+
+### CMake with vcpkg integration
+
+Navigate to [vcpkg-example](./vcpkg-example) for how to import the `pulsar-client-cpp` into your project via vcpkg.
+
+### Download pre-built binaries
+
+For non-vcpkg projects, you can download pre-built binaries from the [official release page](https://pulsar.apache.org/download/#pulsar-c-client).

Review Comment:
   Maybe we also need to update this doc? https://pulsar.apache.org/docs/3.1.x/client-libraries-cpp/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org