You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/07 02:42:00 UTC
[jira] [Commented] (FLINK-6667) Pass a callback type to the
RestartStrategy, rather than the full ExecutionGraph
[ https://issues.apache.org/jira/browse/FLINK-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077496#comment-16077496 ]
ASF GitHub Bot commented on FLINK-6667:
---------------------------------------
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4277
[FLINK-6667] Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph
… the full ExecutionGraph
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-6667
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4277
----
commit e1b8b8ca4a8d1bbff61a6de8547eaf1c2e140669
Author: zjureel <zj...@gmail.com>
Date: 2017-07-07T02:37:42Z
[FLINK-6667] Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph
----
> Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph
> --------------------------------------------------------------------------------
>
> Key: FLINK-6667
> URL: https://issues.apache.org/jira/browse/FLINK-6667
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Stephan Ewen
>
> To let the {{ResourceStrategy}} work across multiple {{FailoverStrategy}} implementations, it needs to be passed a "callback" to call to trigger the restart of tasks/regions/etc.
> Such a "callback" would be a nice abstraction to use for global restarts as well, to not expose the full execution graph.
> Ideally, the callback is one-shot, so it cannot accidentally be used to call restart() multiple times.
> This would also make the testing of RestartStrategies much easier.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)