You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/28 15:16:57 UTC

[GitHub] [pulsar] aloyszhang opened a new pull request #14496: Support ManagedLedger EntryCache cache entires before the slowest cursor

aloyszhang opened a new pull request #14496:
URL: https://github.com/apache/pulsar/pull/14496


   
   Fixes #14495 
   
   ### Motivation
   
    Support ManagedLedger EntryCache cache entries before the slowest cursor 
   
   ### Modifications
   1. Add a new configuration `managedLedgerCacheEvictionSkipSlowestCursor` to control whether the cacheEvictionTask will remove entries read by all active cursors.
   2. add test  EntryCacheManagerTest#verifyEvictionSkipSlowestCursor
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   `EntryCacheManagerTest#verifyEvictionSkipSlowestCursor`
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
     
   - [ ] `no-need-doc` 
     
     (Please explain why)
     
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaozhangmin commented on pull request #14496: Support ManagedLedger EntryCache cache entires before the slowest cursor

Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14496:
URL: https://github.com/apache/pulsar/pull/14496#issuecomment-1054960034


   @aloyszhang  I think this config is not flexible， remain read message in cache will impact the catch-up read.   After we catch up, We need to turn it off.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14496: [WIP]Support ManagedLedger EntryCache cache entires before the slowest cursor

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14496:
URL: https://github.com/apache/pulsar/pull/14496#issuecomment-1086484713


   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] aloyszhang commented on pull request #14496: Support ManagedLedger EntryCache cache entires before the slowest cursor

Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #14496:
URL: https://github.com/apache/pulsar/pull/14496#issuecomment-1054886299


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14496: Support ManagedLedger EntryCache cache entires before the slowest cursor

Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #14496:
URL: https://github.com/apache/pulsar/pull/14496#issuecomment-1054960034


   @aloyszhang  I think this config is not flexible， remain read message in cache will impact the catch-up read.   After we catch up, If We want to turn it off, We cannot do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14496: Support ManagedLedger EntryCache cache entires before the slowest cursor

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14496:
URL: https://github.com/apache/pulsar/pull/14496#issuecomment-1054360518


   @aloyszhang:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org