You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/05 07:23:18 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #11776: [Improvement] [Doc] Put default task parameters in a new file
EricGao888 opened a new pull request, #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776
## Purpose of the pull request
* Still WIP, will polish related docs and fix Chinese version docs in the following commits.
* Put the docs for task plugin default parameters in a separate file for better maintainability.
* This PR closes: #11687
## Brief change log
* Already described above.
## Verify this pull request
This pull request is docs cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11776: [Improvement] [Doc] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776#issuecomment-1247634741
> > @caishunfeng This PR also needs to cherry pick to 3.1.0, thanks
>
> OK, and this is the improvement, should this pr cherry-pick to 3.0.1? @zhongjiajie @EricGao888
maybe only 3.1.0, cherry-pick to 3.0.1 may cause many conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #11776: [Improvement] [Doc] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776#issuecomment-1247621808
> @caishunfeng This PR also needs to cherry pick to 3.1.0, thanks
OK, and this is the improvement, should this pr cherry-pick to 3.0.1? @zhongjiajie @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11776: [Improvement] [Doc] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776#issuecomment-1247497634
Does @SbloodyS have other idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11776: [Improvement] [Doc] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776#issuecomment-1247504966
@caishunfeng This PR also needs to cherry pick to 3.1.0, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #11776: [Improvement] [Doc] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776#issuecomment-1247501274
> Does @SbloodyS have other idea?
Nope. That's great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #11776: [Improvement] [Doc] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11776: [Improvement] [Doc] Put default task parameters in a new file
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11776:
URL: https://github.com/apache/dolphinscheduler/pull/11776#issuecomment-1247637754
> > > @caishunfeng This PR also needs to cherry pick to 3.1.0, thanks
>
> >
>
> > OK, and this is the improvement, should this pr cherry-pick to 3.0.1? @zhongjiajie @EricGao888
>
>
>
> maybe only 3.1.0, cherry-pick to 3.0.1 may cause many conflict
+1，this PR is for better maintainability, it is unnecessary to pick it into 3.0.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org