You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/26 10:05:33 UTC

[GitHub] [beam] lazylynx commented on a change in pull request #12239: [BEAM-9980] tests tied with Python versions configurable

lazylynx commented on a change in pull request #12239:
URL: https://github.com/apache/beam/pull/12239#discussion_r460507051



##########
File path: build.gradle
##########
@@ -243,13 +241,16 @@ task pythonFormatterPreCommit() {
   dependsOn 'sdks:python:test-suites:tox:py38:formatter'
 }
 
+task pythonPostCommit() {

Review comment:
       This task `pythonPostCommit` aims to trigger tasks whose python versions defined in gradle.properties, which should not to be triggered by PostCommit tasks with versions like `python2PostCommit`.
   We must reconsider this task configuration when introducing high/low priority.
   
   Did I answer your comment? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org