You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/12 07:56:32 UTC
[GitHub] [airflow] yuqian90 opened a new pull request #7143: [AIRFLOW-6527]
Make send_task_to_executor timeout configurable
yuqian90 opened a new pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143
This change makes the timeout for sending tasks to Celery worker configurable. If people encounter the same Celery timeout error described in AIRFLOW-6527, they may increase `[celery]send_task_timeout` to make the timeout less likely to happen.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] yuqian90 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365798474
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
@mik-laj okay I see your point. I updated to all lower case.
However, I do see a lot of places where conf entries are queried like this:
e.g.
```
airflow/bin/cli.py
'worker_timeout': Arg(
("-t", "--worker_timeout"),
default=conf.get('webserver', 'WEB_SERVER_WORKER_TIMEOUT'),
type=int,
help="The timeout for waiting on webserver workers"),
airflow/utils/log/file_task_handler.py
url = os.path.join(
"http://{ti.hostname}:{worker_log_server_port}/log", log_relative_path
).format(
ti=ti,
worker_log_server_port=conf.get('celery', 'WORKER_LOG_SERVER_PORT')
)
```
So something strange is going on. I did not spend much time looking into this though since that's not what I originally intended to investigate. One possibility is this old change was not applied globally correctly. That's just my speculation: https://github.com/apache/airflow/pull/5668/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7143: [AIRFLOW-6527] Make
send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] yuqian90 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365645307
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
I think since a recent release, the conf entries are no longer case sensitive. I see conf.get* with capitcal cases all over the place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.28% 85% -0.29%
=========================================
Files 707 707
Lines 39255 39256 +1
=========================================
- Hits 33478 33368 -110
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [ab80880...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] yuqian90 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365645312
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
fallback is not needed because `AirflowConfigParser.get()` looks in default_airflow.cfg if the entry is not found. I set it to 2 in `default_airflow.cfg` so we don't need explicit fallback here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/8858a9107eac97cbc85978e909e6d6b85a2c211f?src=pr&el=desc) will **decrease** coverage by `52.78%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
===========================================
- Coverage 85.33% 32.54% -52.79%
===========================================
Files 791 790 -1
Lines 40137 40125 -12
===========================================
- Hits 34252 13060 -21192
- Misses 5885 27065 +21180
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `85.13% <100%> (-3.31%)` | :arrow_down: |
| [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...flow/contrib/example\_dags/example\_qubole\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX3F1Ym9sZV9zZW5zb3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [...ample\_dags/example\_emr\_job\_flow\_automatic\_steps.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2Vtcl9qb2JfZmxvd19hdXRvbWF0aWNfc3RlcHMucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [...contrib/example\_dags/example\_papermill\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX3BhcGVybWlsbF9vcGVyYXRvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| ... and [648 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [8858a91...69a9a9a](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r370939414
##########
File path: airflow/config_templates/config.yml
##########
@@ -1159,6 +1159,14 @@
type: string
example: ~
default: "prefork"
+ - name: operation_timeout
+ description: |
+ The number of seconds to wait before timing out send task or fetch task state operations
Review comment:
```suggestion
The number of seconds to wait before timing out ``send_task`` (``fetch_celery_task_state``) or ``fetch_task`` (``send_task_to_executor``) state operations
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7143: [AIRFLOW-6527] Make
send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] yuqian90 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r369478045
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -537,6 +537,9 @@ ssl_cacert =
# https://docs.celeryproject.org/en/latest/userguide/concurrency/eventlet.html
pool = prefork
+# The number of seconds to wait before timing out apply_async
+connection_timeout = 2
Review comment:
You are right. To be precise, this will become the timeout for `fetch_celery_task_state()` and `send_task_to_executor()`. I could not come up with a perfect name for it. I'm open to suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r370939852
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+OPERATION_TIMEOUT = conf.getint('celery', 'operation_timeout')
Review comment:
Can we add a test for this? Let's say a user change this setting to `conf.get('celery', 'operation_timeout')` that test should fail.
Also let's add a fallback value.
```
OPERATION_TIMEOUT = conf.getint('celery', 'operation_timeout', fallback=2)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365746892
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
<img width="720" alt="Screenshot 2020-01-13 at 12 03 35" src="https://user-images.githubusercontent.com/12058428/72250800-bf8de680-35fc-11ea-889c-10223c44636b.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r369470809
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -537,6 +537,9 @@ ssl_cacert =
# https://docs.celeryproject.org/en/latest/userguide/concurrency/eventlet.html
pool = prefork
+# The number of seconds to wait before timing out apply_async
+connection_timeout = 2
Review comment:
@ashb what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.28% 85% -0.29%
=========================================
Files 707 707
Lines 39255 39256 +1
=========================================
- Hits 33478 33368 -110
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [ab80880...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4e7bb5f2553d4dee68b2bdcbebd944462acee957?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
==========================================
- Coverage 85.33% 85.05% -0.28%
==========================================
Files 791 791
Lines 40137 40138 +1
==========================================
- Hits 34251 34141 -110
- Misses 5886 5997 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [4e7bb5f...21e20aa](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365566666
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
```suggestion
SEND_TASK_TIMEOUT = conf.getint('celery', 'send_task_timeout')
```
The key is case sensitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365567006
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
```suggestion
SEND_TASK_TIMEOUT = conf.getint('celery', 'CONNECTION_TIMEOUT')
```
You also wanna use timeout for fetching task states.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365606306
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
really? i see all lower in cfg but lots of upper in python code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4e7bb5f2553d4dee68b2bdcbebd944462acee957?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
==========================================
- Coverage 85.33% 85.05% -0.28%
==========================================
Files 791 791
Lines 40137 40138 +1
==========================================
- Hits 34251 34141 -110
- Misses 5886 5997 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [4e7bb5f...21e20aa](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] yuqian90 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r370982982
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+OPERATION_TIMEOUT = conf.getint('celery', 'operation_timeout')
Review comment:
Thanks, @kaxil. Done. I added a very boring test like this. It'll detect mistakes such as the example you showed. Pls let me know if you are looking for something better.
```python
def test_operation_timeout_config():
assert celery_executor.OPERATION_TIMEOUT == 2
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.28% 85% -0.29%
=========================================
Files 707 707
Lines 39255 39256 +1
=========================================
- Hits 33478 33368 -110
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [ab80880...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.28% 85% -0.29%
=========================================
Files 707 707
Lines 39255 39256 +1
=========================================
- Hits 33478 33368 -110
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [ab80880...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] yuqian90 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365798474
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
@mik-laj okay I see your point. I updated to all lower case.
However, I do see a lot of places where conf entries are queried like this:
e.g.
```
airflow/bin/cli.py
'worker_timeout': Arg(
("-t", "--worker_timeout"),
default=conf.get('webserver', 'WEB_SERVER_WORKER_TIMEOUT'),
type=int,
help="The timeout for waiting on webserver workers"),
airflow/utils/log/file_task_handler.py
url = os.path.join(
"http://{ti.hostname}:{worker_log_server_port}/log", log_relative_path
).format(
ti=ti,
worker_log_server_port=conf.get('celery', 'WORKER_LOG_SERVER_PORT')
)
```
So something strange is going on. I did not spend much time looking into this thought since that's not what I originally intended to investigate. One possibility is this old change was not applied globally correctly. That's just my speculation: https://github.com/apache/airflow/pull/5668/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] yuqian90 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r370933947
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -537,6 +537,9 @@ ssl_cacert =
# https://docs.celeryproject.org/en/latest/userguide/concurrency/eventlet.html
pool = prefork
+# The number of seconds to wait before timing out apply_async
+connection_timeout = 2
Review comment:
@kaxil @ashb I renamed it to `operation_timeout` because it's the timeout for the `send_task_to_executor()` and `fetch_celery_task_state()` operations. Please let me know if you have better suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r369470733
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -537,6 +537,9 @@ ssl_cacert =
# https://docs.celeryproject.org/en/latest/userguide/concurrency/eventlet.html
pool = prefork
+# The number of seconds to wait before timing out apply_async
+connection_timeout = 2
Review comment:
Is it actually a `connection_timeout`? Trying to think if we can call it something specific to apply_async
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365565050
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
add ,fallback=2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7143:
[AIRFLOW-6527] Make send_task_to_executor timeout configurable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7143: [AIRFLOW-6527] Make send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#issuecomment-573518018
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=h1) Report
> Merging [#7143](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a676f159d4fb01f6e35baa04efa4914a695cd788?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7143 +/- ##
=========================================
- Coverage 85.24% 85% -0.25%
=========================================
Files 683 707 +24
Lines 39155 39256 +101
=========================================
- Hits 33378 33368 -10
- Misses 5777 5888 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (+0.07%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
| [airflow/contrib/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvaGRmc19zZW5zb3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/sensors/hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL2hkZnNfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | | |
| ... and [48 more](https://codecov.io/gh/apache/airflow/pull/7143/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=footer). Last update [a676f15...c8ac850](https://codecov.io/gh/apache/airflow/pull/7143?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services