You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/11/09 04:47:46 UTC

[GitHub] tajo pull request: TAJO-1971: Replace 'for' loop with 'foreach'

GitHub user dkhwangbo opened a pull request:

    https://github.com/apache/tajo/pull/855

    TAJO-1971: Replace 'for' loop with 'foreach'

    Reports for loops which iterate over collections or arrays, and can be replaced with the foreach iteration syntax, available in Java 5 and newer, to get the improvement of readability and so on.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhwangbo/tajo TAJO-1971

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/855.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #855
    
----
commit 61b3d654bfa272776974c952e209f0b6461af2ee
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date:   2015-11-09T03:45:53Z

    initial commit

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1971: Replace 'for' loop with 'foreach'

Posted by dkhwangbo <gi...@git.apache.org>.

Github user dkhwangbo commented on the pull request:

    https://github.com/apache/tajo/pull/855#issuecomment-160505136
  
    I'll re-make same PR with latest master. It's more easy than resolving conflict.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1971: Replace 'for' loop with 'foreach'

Posted by dkhwangbo <gi...@git.apache.org>.

Github user dkhwangbo closed the pull request at:

    https://github.com/apache/tajo/pull/855


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1971: Replace 'for' loop with 'foreach'

Posted by eminency <gi...@git.apache.org>.

Github user eminency commented on the pull request:

    https://github.com/apache/tajo/pull/855#issuecomment-160504334
  
    Could you merge latest master branch please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---