You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/10 07:42:49 UTC

[GitHub] [pulsar] Shoothzj opened a new pull request #12713: Remove unnecessary powermock annotation

Shoothzj opened a new pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713


   ### Motivation
   Remove unnecessary powermock annotation. I think that can make tests run faster.
   
   ### Verifying this change
   run test local ok.
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
     
     little modification for test code.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-964993360


   > `you mean run again use jdk8 ?`
   > 
   > yes
   I tested, they can paas both on jdk8 and jdk11 :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-964890662


   > I am +1 as long as the tests that we modified pass both on JDK11 and on JDK8
   > 
   > those annotations where there because of some weird behaviour on some JDK
   > 
   > @Shoothzj can you please verify ?
   
   I have runned use jdk11, you mean run again use jdk8 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-964888353


   I am +1 as long as the tests that we modified pass both on JDK11 and on JDK8
   
   those annotations where there because of some weird behaviour on some JDK
   
   @Shoothzj can you please verify ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj closed pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-965822456


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-964899448


   `you mean run again use jdk8 ?`
   
   yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-964973842


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj removed a comment on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-964918333






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj commented on pull request #12713: Remove unnecessary powermock annotation

Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12713:
URL: https://github.com/apache/pulsar/pull/12713#issuecomment-964918333


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org