You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2019/10/15 14:45:04 UTC
[kudu-CR] master: fix the value of table metric 'live row count'
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14446
Change subject: master: fix the value of table metric 'live_row_count'
......................................................................
master: fix the value of table metric 'live_row_count'
When the tablet doesn't support live row counting, the
'live_row_count' metric of the tablet is '-1'. But when
master aggregates all tablets' metric of a table, it sums
up all '-1's, and the result value is confusing to users.
It's better to set it '-1' to be consistent with tablet metric.
Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/table_metrics.cc
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/14446/1
--
To view, visit http://gerrit.cloudera.org:8080/14446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc
Gerrit-Change-Number: 14446
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] master: fix the value of table metric 'live row count'
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14446 )
Change subject: master: fix the value of table metric 'live_row_count'
......................................................................
Patch Set 1:
Could you add a unit test for this? Perhaps in master-test, where you can send the master synthetic heartbeats with -1 in the tablet's live row count?
--
To view, visit http://gerrit.cloudera.org:8080/14446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc
Gerrit-Change-Number: 14446
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 20:29:43 +0000
Gerrit-HasComments: No
[kudu-CR] master: fix the value of table metric 'live row count'
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14446 )
Change subject: master: fix the value of table metric 'live_row_count'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc
Gerrit-Change-Number: 14446
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 16:01:06 +0000
Gerrit-HasComments: No
[kudu-CR] master: fix the value of table metric 'live row count'
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14446 )
Change subject: master: fix the value of table metric 'live_row_count'
......................................................................
master: fix the value of table metric 'live_row_count'
When the tablet doesn't support live row counting, the
'live_row_count' metric of the tablet is '-1'. But when
master aggregates all tablets' metric of a table, it sums
up all '-1's, and the result value is confusing to users.
It's better to set it '-1' to be consistent with tablet metric.
Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc
Reviewed-on: http://gerrit.cloudera.org:8080/14446
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <40...@qq.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/table_metrics.cc
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc
Gerrit-Change-Number: 14446
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] master: fix the value of table metric 'live row count'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14446 )
Change subject: master: fix the value of table metric 'live_row_count'
......................................................................
Patch Set 1: Code-Review+2
I think we can merge it without the test and include the fix into 1.11 RC2. We can add the test after.
--
To view, visit http://gerrit.cloudera.org:8080/14446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f837466a0420dafef4f9426929b7b1622702ffc
Gerrit-Change-Number: 14446
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 16 Oct 2019 19:59:24 +0000
Gerrit-HasComments: No