You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Philip Zeyliger (Created) (JIRA)" <ji...@apache.org> on 2011/10/29 04:31:32 UTC

[jira] [Created] (AVRO-949) NettyTransiever doesn't call RPCPlugin.clientReceiveResponse on the same thread as clientSendRequest

NettyTransiever doesn't call RPCPlugin.clientReceiveResponse on the same thread as clientSendRequest
----------------------------------------------------------------------------------------------------

                 Key: AVRO-949
                 URL: https://issues.apache.org/jira/browse/AVRO-949
             Project: Avro
          Issue Type: Bug
    Affects Versions: 1.5.4, 1.6.0
            Reporter: Philip Zeyliger


RPCPlugin.clientReceiveResponse() is called in the Netty IO thread when using a NettyTransceiver.  This is quite different than how HTTPTransceiver does it.

Users can use RPCPlugin to do things like tracing and timing. It's bizarre that clientSendRequest() happens in the caller's thread, but clientReceiveResponse() happens in a different one, because thread locals are one of the easiest way to pass information between these.  There's no easy other way, since RPCContext, which is passed along, has no way to associate arbitrary data with itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-949) NettyTransiever doesn't call RPCPlugin.clientReceiveResponse on the same thread as clientSendRequest

Posted by "Doug Cutting (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139310#comment-13139310 ] 

Doug Cutting commented on AVRO-949:
-----------------------------------

Maybe we should add 'Map<Object,Object> getProps()' to RpcPlugin? 
                
> NettyTransiever doesn't call RPCPlugin.clientReceiveResponse on the same thread as clientSendRequest
> ----------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-949
>                 URL: https://issues.apache.org/jira/browse/AVRO-949
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.5.4, 1.6.0
>            Reporter: Philip Zeyliger
>
> RPCPlugin.clientReceiveResponse() is called in the Netty IO thread when using a NettyTransceiver.  This is quite different than how HTTPTransceiver does it.
> Users can use RPCPlugin to do things like tracing and timing. It's bizarre that clientSendRequest() happens in the caller's thread, but clientReceiveResponse() happens in a different one, because thread locals are one of the easiest way to pass information between these.  There's no easy other way, since RPCContext, which is passed along, has no way to associate arbitrary data with itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-949) NettyTransiever doesn't call RPCPlugin.clientReceiveResponse on the same thread as clientSendRequest

Posted by "Doug Cutting (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139311#comment-13139311 ] 

Doug Cutting commented on AVRO-949:
-----------------------------------

RPCContext, I mean.
                
> NettyTransiever doesn't call RPCPlugin.clientReceiveResponse on the same thread as clientSendRequest
> ----------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-949
>                 URL: https://issues.apache.org/jira/browse/AVRO-949
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.5.4, 1.6.0
>            Reporter: Philip Zeyliger
>
> RPCPlugin.clientReceiveResponse() is called in the Netty IO thread when using a NettyTransceiver.  This is quite different than how HTTPTransceiver does it.
> Users can use RPCPlugin to do things like tracing and timing. It's bizarre that clientSendRequest() happens in the caller's thread, but clientReceiveResponse() happens in a different one, because thread locals are one of the easiest way to pass information between these.  There's no easy other way, since RPCContext, which is passed along, has no way to associate arbitrary data with itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira