You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/01 05:51:00 UTC
[jira] [Commented] (DRILL-6731) JPPD:Move aggregating the BF from
the Foreman to the RuntimeFilter
[ https://issues.apache.org/jira/browse/DRILL-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633629#comment-16633629 ]
ASF GitHub Bot commented on DRILL-6731:
---------------------------------------
sohami commented on a change in pull request #1459: DRILL-6731: Move the BFs aggregating work from the Foreman to the RuntimeFi…
URL: https://github.com/apache/drill/pull/1459#discussion_r221490851
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/RuntimeFilterVisitor.java
##########
@@ -223,16 +223,16 @@ public Void visitJoin(JoinPrel prel, RFHelperHolder holder) throws RuntimeExcept
right.accept(this, holder);
boolean routeToForeman = holder.needToRouteToForeman();
if (!routeToForeman) {
- runtimeFilterDef.setSendToForeman(false);
+ runtimeFilterDef.setSendToForeman(!routeToForeman);
} else {
- runtimeFilterDef.setSendToForeman(true);
+ runtimeFilterDef.setSendToForeman(routeToForeman);
}
List<BloomFilterDef> bloomFilterDefs = runtimeFilterDef.getBloomFilterDefs();
for (BloomFilterDef bloomFilterDef : bloomFilterDefs) {
if (!routeToForeman) {
- bloomFilterDef.setLocal(true);
+ bloomFilterDef.setLocal(!routeToForeman);
} else {
- bloomFilterDef.setLocal(false);
+ bloomFilterDef.setLocal(routeToForeman);
Review comment:
Same here you can remove `if-else` block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> JPPD:Move aggregating the BF from the Foreman to the RuntimeFilter
> ------------------------------------------------------------------
>
> Key: DRILL-6731
> URL: https://issues.apache.org/jira/browse/DRILL-6731
> Project: Apache Drill
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.15.0
> Reporter: weijie.tong
> Assignee: weijie.tong
> Priority: Major
>
> This PR is to move the BloomFilter aggregating work from the foreman to RuntimeFilter. Though this change, the RuntimeFilter can apply the incoming BF as soon as possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)