[jira] [Commented] (BEAM-5379) Go Modules versioning support

["Nathan Fisher (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821668#comment-16821668 ] 

Nathan Fisher commented on BEAM-5379:
-------------------------------------

[~lostluck] what are the main blockers on this?

Seems in order to close out this issue it would require:

* inclusion of go.mod and go.sum.
* updated README.md in {{sdks/go}}.
* updated gradle build.

Anything else? I've opened a draft PR and tagged lostluck in a comment.

> Go Modules versioning support
> -----------------------------
>
>                 Key: BEAM-5379
>                 URL: https://issues.apache.org/jira/browse/BEAM-5379
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Robert Burke
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This would make it easier for non-Go developers to update and test changes to the Go SDK without jumping through hoops to set up Go Paths at first.
> Right now, we us the gogradle plugin for gradle to handle re-producible builds. Without doing something with the GO_PATH relative to a user's local git repo though, changes made in the user's repo are not represented when gradle is invoked to test everything.
> One of at least the following needs to be accomplished:
> * gogradle moves to support the Go Modules experiment in Go 1.11, and the SDK migrates to that
> * or we re-implement our gradle go rules ourselves to use them, 
> * or some third option, that moves away from the GO_PATH nit.
> This issue should be resolved after deciding and implementing a clear versioning story for the SDK, ideally along Go best practices.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)