[GitHub] merlimat commented on a change in pull request #3443: [go-client] integrated `logrus`, `testify` and `go mod` for pulsar-client-go

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #3443: [go-client] integrated `logrus`, `testify` and `go mod` for pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3443#discussion_r251202162
 
 

 ##########
 File path: pulsar-client-go/pulsar/c_go_pulsar.h
 ##########
 @@ -25,16 +25,6 @@
 
 // Callback proxy functions
 
-void pulsarClientLoggerProxy(pulsar_logger_level_t level, char* file, int line, char* message, void *ctx);
-
-static inline void pulsarClientLoggerConstProxy(pulsar_logger_level_t level, const char* file, int line, const char* message, void *ctx) {
-    pulsarClientLoggerProxy(level, (char*)file, line, (char*)message, ctx);
-}
-
-static inline void _pulsar_client_configuration_set_logger(pulsar_client_configuration_t *conf, void *ctx) {
 
 Review comment:
   This is used to route all the C++ library logs into a Go logger function. If we don't have this, all logs from C++ lib will be printed with a different format on stdout.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services