You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by "Kirk Lund (JIRA)" <ji...@apache.org> on 2017/03/30 16:03:41 UTC

[jira] [Created] (GEODE-2735) CliUtil.isGfshVM is not thread-safe and unnecessary

Kirk Lund created GEODE-2735:
--------------------------------

             Summary: CliUtil.isGfshVM is not thread-safe and unnecessary
                 Key: GEODE-2735
                 URL: https://issues.apache.org/jira/browse/GEODE-2735
             Project: Geode
          Issue Type: Bug
          Components: gfsh
            Reporter: Kirk Lund


The top of CliUtil defines:
{noformat}
public static final String GFSHVM_IDENTIFIER = "gfsh";
public static boolean isGfshVM = Boolean.getBoolean(GFSHVM_IDENTIFIER);
{noformat}
Tests then set isGfshVM and unset that in setup/teardown. Various GFSH commands check the state of this boolean.

It would be thread-safe if it were volatile, but I'd prefer to just get rid of this static variable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)