NodeRevisionContent.getContent() bug

["Pill, Juergen" <Ju...@softwareag.com>]

Hello,

To my understanding the method "NodeRevisionContent.getContent()" is not
implemented correctly.

I have applied following changes to the class file:

1) removed the unnecessary field binaryContent
2) Implemented all 3 options in getContent()  [ content, inputStream, reader
]
3) Some minor changes in more functions to deal with the case either
content, inputStream or reader is set.
4) Implemented 2 private methods to read content from a stream and a reader.


Does this make sense. Please see attached file.

By the way: Wouldn't it be better to store the content as a byte[] instead
of a char[]. If binary data is send, this may cause problems?

Best regards and a happy new year to all of you

Juergen Pill



 <<NodeRevisionContent.java>> 

Re: NodeRevisionContent.getContent() bug

[Remy Maucherat <re...@betaversion.org>]

Quoting "Pill, Juergen" <Ju...@softwareag.com>:

> Hello,
> 
> To my understanding the method "NodeRevisionContent.getContent()" is
> not
> implemented correctly.

Use streamContent() for now. The others are old dead code (until I apply your 
patch to address this).

Remy