You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/12/04 01:30:00 UTC

Review Request 28681: Made GC_DISK_HEADROOM configurable.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28681/
-----------------------------------------------------------

Review request for mesos, Adam B and Vinod Kone.


Bugs: MESOS-2169
    https://issues.apache.org/jira/browse/MESOS-2169


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/slave/flags.hpp 4f5b8b405925a41b8b6961fd25d7ff6e8699fa68 
  src/slave/slave.cpp 9ac64589c353b2f17f538db7de01faa55b2369b9 

Diff: https://reviews.apache.org/r/28681/diff/


Testing
-------

make check and functional testing.


Thanks,

Niklas Nielsen

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28681/#review63794
-----------------------------------------------------------


Patch looks great!

Reviews applied: [28681]

All tests passed.

- Mesos ReviewBot


On Dec. 4, 2014, 12:29 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28681/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 12:29 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2169
>     https://issues.apache.org/jira/browse/MESOS-2169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 4f5b8b405925a41b8b6961fd25d7ff6e8699fa68 
>   src/slave/slave.cpp 9ac64589c353b2f17f538db7de01faa55b2369b9 
> 
> Diff: https://reviews.apache.org/r/28681/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

Posted by Niklas Nielsen <ni...@qni.dk>.


> On Dec. 4, 2014, 6:20 a.m., Adam B wrote:
> > src/slave/slave.cpp, line 284
> > <https://reviews.apache.org/r/28681/diff/1/?file=782157#file782157line284>
> >
> >     Can it even be ==0 or ==1?

Shouldn't change much. You can still do 0.0001 or 0.9999 while being exclusive.

The age calculation:
flags.gc_delay * std::max(0.0, (1.0 - flags.gc_disk_headroom - usage))

gc_disk_headroom = 1 gives 0
gc_disk_headroom = 0 gives flags.gc_delay * (1.0 - usage)

So should be safe in both cases


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28681/#review63842
-----------------------------------------------------------


On Dec. 3, 2014, 4:29 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28681/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 4:29 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2169
>     https://issues.apache.org/jira/browse/MESOS-2169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 4f5b8b405925a41b8b6961fd25d7ff6e8699fa68 
>   src/slave/slave.cpp 9ac64589c353b2f17f538db7de01faa55b2369b9 
> 
> Diff: https://reviews.apache.org/r/28681/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

Posted by Adam B <ad...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28681/#review63842
-----------------------------------------------------------

Ship it!


LGTM, just wondering about inclusive/exclusive [0,1] vs. (0,1)


src/slave/slave.cpp
<https://reviews.apache.org/r/28681/#comment106146>

    Can it even be ==0 or ==1?


- Adam B


On Dec. 3, 2014, 4:29 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28681/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 4:29 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2169
>     https://issues.apache.org/jira/browse/MESOS-2169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 4f5b8b405925a41b8b6961fd25d7ff6e8699fa68 
>   src/slave/slave.cpp 9ac64589c353b2f17f538db7de01faa55b2369b9 
> 
> Diff: https://reviews.apache.org/r/28681/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 28681: Made GC_DISK_HEADROOM configurable.

Posted by Alexander Rukletsov <al...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28681/#review63824
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rukletsov


On Dec. 4, 2014, 12:29 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28681/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 12:29 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2169
>     https://issues.apache.org/jira/browse/MESOS-2169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 4f5b8b405925a41b8b6961fd25d7ff6e8699fa68 
>   src/slave/slave.cpp 9ac64589c353b2f17f538db7de01faa55b2369b9 
> 
> Diff: https://reviews.apache.org/r/28681/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>