[GitHub] [spark] srielau commented on pull request #42661: [SPARK-44743][SQL] Fix `reflect` method behavior match with hive

["srielau (via GitHub)" <gi...@apache.org>]

srielau commented on PR #42661:
URL: https://github.com/apache/spark/pull/42661#issuecomment-1692021742

   > I don't think we should blindly follow hive, but it seems a reasonable requirement to specify the failure behavior of the `reflect` function.
   > 
   > @srielau any ideas? Shall we add a new parameter to this function or add another function with a different name?
   
   If we are consistent, we add try_reflect.
   We could hitch the NULL for reflect to ansi_enabled = false.
   Isn't it in the users best interest to know when a function raises an error? suppressing it leads to silent, undetected errors.
   And NULL may well be part of expected results, so it wouldn't raise an eyebrow. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org