[GitHub] [ignite-3] isapego commented on a diff in pull request #1594: IGNITE-18291 Enhance C++ Binary Tuple code

["isapego (via GitHub)" <gi...@apache.org>]

isapego commented on code in PR #1594:
URL: https://github.com/apache/ignite-3/pull/1594#discussion_r1088996948


##########
modules/platforms/cpp/ignite/client/sql/column_metadata.h:
##########
@@ -18,7 +18,7 @@
 #pragma once
 
 #include "ignite/client/sql/column_origin.h"
-#include "ignite/client/sql/sql_column_type.h"
+#include "ignite/schema/ignite_type.h"

Review Comment:
   This is not good. `schema` is not a public library for client, so removal of `sql_column_type` here should be reversed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org