[GitHub] [airflow] potiuk edited a comment on issue #5779: [AIRLFOW-5163] Default do_xcom_push to False

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #5779: [AIRLFOW-5163] Default do_xcom_push to False
URL: https://github.com/apache/airflow/pull/5779#issuecomment-538953236
 
 
   This is quite drastic change.
   
   While I agree it should be done, I think this change should also set do_xcom_push to `True` for all the operators that currently return a value from execute and do not have "do_xcom_push" set  (after checking that it's intentional). It should be rather safe and easy change.
   
   I think it's not enough to write it in updating.md in this case. There will be weird, unrelated problems if they do_xcom_push is set to False for DAGs that rely on it. Often you will see missing or empty value in a task that is further upstream and I imagine this to be nightmare to debug for huge DAGs.
   
   I did a quick search for operators that do not have *do_xcom_push* but they have some "return\s\S.*$" regexp. They might of course have false positives of course (but by quick look - not many). I think the list is large enough to worry, but small enough that such review and global change is actually doable in short time.
   
   ```
   ./airflow/sensors/base_sensor_operator.py
   ./airflow/operators/hive_stats_operator.py
   ./airflow/operators/druid_check_operator.py
   ./airflow/operators/presto_check_operator.py
   ./airflow/operators/pig_operator.py
   ./airflow/operators/http_operator.py
   ./airflow/operators/subdag_operator.py
   ./airflow/operators/hive_operator.py
   ./airflow/operators/python_operator.py
   ./airflow/operators/check_operator.py
   ./airflow/operators/docker_operator.py
   ./airflow/operators/branch_operator.py
   ./airflow/operators/s3_to_hive_operator.py
   ./airflow/operators/dagrun_operator.py
   ./airflow/operators/bash_operator.py
   ./airflow/contrib/operators/sagemaker_model_operator.py
   ./airflow/contrib/operators/adls_list_operator.py
   ./airflow/contrib/operators/azure_container_instances_operator.py
   ./airflow/contrib/operators/aws_athena_operator.py
   ./airflow/contrib/operators/sagemaker_tuning_operator.py
   ./airflow/contrib/operators/opsgenie_alert_operator.py
   ./airflow/contrib/operators/sagemaker_training_operator.py
   ./airflow/contrib/operators/qubole_check_operator.py
   ./airflow/contrib/operators/jira_operator.py
   ./airflow/contrib/operators/kubernetes_pod_operator.py
   ./airflow/contrib/operators/s3_to_sftp_operator.py
   ./airflow/contrib/operators/jenkins_job_trigger_operator.py
   ./airflow/contrib/operators/databricks_operator.py
   ./airflow/contrib/operators/grpc_operator.py
   ./airflow/contrib/operators/snowflake_operator.py
   ./airflow/contrib/operators/sftp_to_s3_operator.py
   ./airflow/contrib/operators/s3_list_operator.py
   ./airflow/contrib/operators/sftp_operator.py
   ./airflow/contrib/operators/aws_sqs_publish_operator.py
   ./airflow/contrib/operators/winrm_operator.py
   ./airflow/contrib/operators/sagemaker_endpoint_config_operator.py
   ./airflow/contrib/operators/sns_publish_operator.py
   ./airflow/contrib/operators/wasb_delete_blob_operator.py
   ./airflow/contrib/operators/s3_to_gcs_operator.py
   ./airflow/contrib/operators/ssh_operator.py
   ./airflow/contrib/operators/sagemaker_endpoint_operator.py
   ./airflow/contrib/operators/qubole_operator.py
   ./airflow/contrib/operators/sagemaker_transform_operator.py
   ./airflow/contrib/operators/emr_create_job_flow_operator.py
   ./airflow/contrib/operators/emr_add_steps_operator.py
   ./airflow/contrib/operators/ecs_operator.py
   ./airflow/contrib/operators/awsbatch_operator.py
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services