You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/03/01 02:38:33 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #197: Use one docker image for all of Tuweni
atoulme opened a new pull request #197:
URL: https://github.com/apache/incubator-tuweni/pull/197
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
We had multiple docker images, but since we're working on having a binary distro with all our executables, we can create a docker image that defaults to the tuweni executable, but also allows folks to override and use other scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #197: Use one docker image for all of Tuweni
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #197:
URL: https://github.com/apache/incubator-tuweni/pull/197#issuecomment-787599188
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=h1) Report
> Merging [#197](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=desc) (f98c5b3) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/985039fa7158a82bf9c268359f97bc0e8873f550?el=desc) (985039f) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #197 +/- ##
============================================
+ Coverage 60.33% 60.36% +0.03%
Complexity 3898 3898
============================================
Files 358 358
Lines 19916 19916
Branches 2622 2622
============================================
+ Hits 12017 12023 +6
+ Misses 6547 6542 -5
+ Partials 1352 1351 -1
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| unit | `60.36% <ø> (+0.03%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/197/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `80.85% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/197/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `47.51% <0.00%> (+0.47%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/197/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `51.92% <0.00%> (+1.92%)` | `4.00% <0.00%> (ø%)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/197/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (+5.35%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=footer). Last update [985039f...f98c5b3](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #197: Use one docker image for all of Tuweni
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #197:
URL: https://github.com/apache/incubator-tuweni/pull/197#issuecomment-787599188
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=h1) Report
> Merging [#197](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=desc) (22c7af3) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/985039fa7158a82bf9c268359f97bc0e8873f550?el=desc) (985039f) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #197 +/- ##
============================================
+ Coverage 60.33% 60.36% +0.03%
Complexity 3898 3898
============================================
Files 358 358
Lines 19916 19916
Branches 2622 2622
============================================
+ Hits 12017 12023 +6
+ Misses 6547 6541 -6
Partials 1352 1352
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| unit | `60.36% <ø> (+0.03%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/197/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `47.51% <0.00%> (+0.47%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/197/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `51.92% <0.00%> (+1.92%)` | `4.00% <0.00%> (ø%)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/197/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (+5.35%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=footer). Last update [985039f...f98c5b3](https://codecov.io/gh/apache/incubator-tuweni/pull/197?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #197: Use one docker image for all of Tuweni
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #197:
URL: https://github.com/apache/incubator-tuweni/pull/197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org