You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/03/08 08:00:27 UTC

[GitHub] [skywalking] wu-sheng opened a new issue, #10501: [Feature] Support isEmptyValue flag for metrics query

wu-sheng opened a new issue, #10501:
URL: https://github.com/apache/skywalking/issues/10501

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   In the current case, we always respond to zero if timestamp slots are absent.
   
   I opened https://github.com/apache/skywalking-query-protocol/pull/110 for a protocol update(9.5.0 only), and we could distinguish these two cases. 
   
   ### Use case
   
   `no value`(no metric at this time bucket) V.S. `actual zero value`(such as success rate == 0% or the value is less than 1 due to precision)
   
   @wankai123 According to this, let's evaluate whether the default value still makes sense, or we should remove that permanently. 
   
   FYI @Fine0830 After this lands on the backend, UI should do
   1. Build a flat line cross the absent(isEmptyValue = true) data point. Rather than dropping the line to zero as a peak. 
   2. Skip absent(isEmptyValue = true) data point when the table runs preview avg.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #10501: [Feature] Support isEmptyValue flag for metrics query

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10501:
URL: https://github.com/apache/skywalking/issues/10501#issuecomment-1504896182

   @Fine0830 We need to adopt this on UI widgets.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #10501: [Feature] Support isEmptyValue flag for metrics query

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10501:
URL: https://github.com/apache/skywalking/issues/10501#issuecomment-1461929419

   @Fine0830 With another https://github.com/apache/skywalking-query-protocol/pull/112, query single value should switch this new way and support empty value to show `--` or `no data` on the widget.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #10501: [Feature] Support isEmptyValue flag for metrics query

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10501: [Feature] Support isEmptyValue flag for metrics query
URL: https://github.com/apache/skywalking/issues/10501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #10501: [Feature] Support isEmptyValue flag for metrics query

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10501:
URL: https://github.com/apache/skywalking/issues/10501#issuecomment-1461926441

   @toffentoffen This is what I talked today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #10501: [Feature] Support isEmptyValue flag for metrics query

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10501: [Feature] Support isEmptyValue flag for metrics query
URL: https://github.com/apache/skywalking/issues/10501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org