You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Kirill Lykov <ly...@gmail.com> on 2021/06/22 08:31:26 UTC

Re: [Gandiva] Active maintainers?

Hi,

Could you review https://github.com/apache/arrow/pull/9828?
Looks like a good step forward on the documentation side of Gandiva.
Beside of that some PRs mentioned earlier by Will are still open:
* https://github.com/apache/arrow/pull/9288
* https://github.com/apache/arrow/pull/9289
* https://github.com/apache/arrow/pull/9453
* https://github.com/apache/arrow/pull/10023

On Mon, May 24, 2021 at 8:19 PM Vivekanand Vellanki <vi...@dremio.com>
wrote:

> I have been working with other committers to have the Gandiva PRs merged.
> What you see is the backlog of PRs that need to be merged after the review
> by Projjal.
>
> On Mon, May 24, 2021 at 11:21 PM Will Jones <wi...@gmail.com>
> wrote:
>
> > Hello,
> >
> > Following up on this. Thanks to Projjal for reviewing so many PRs! One
> > issue is it doesn't look like Projjal is a committer and thus those PRs
> are
> > not shown as mergeable.
> >
> > Here are some PRs that looks like they should be ready to merge:
> >
> >
> >    - ARROW-11342 <https://github.com/apache/arrow/pull/9288>
> >    - ARROW-11341 <https://github.com/apache/arrow/pull/9289>
> >    - ARROW-11960 <https://github.com/apache/arrow/pull/9700>
> >    - ARROW-11549 <https://github.com/apache/arrow/pull/9453>
> >    - ARROW-12205 <https://github.com/apache/arrow/pull/9890>
> >    - ARROW-12378 <https://github.com/apache/arrow/pull/10023>
> >    - ARROW-10155 <https://github.com/apache/arrow/pull/10155>
> >
> >
> > Thanks,
> >
> > Will Jones
> >
> > On Mon, Mar 29, 2021 at 1:31 AM Kirill Lykov <ly...@gmail.com>
> > wrote:
> >
> > > Thank you Micah for the effort.
> > > I think [python][gandiva] was added by Anyscale. Earlier, I've managed
> to
> > > invite them for the commit review yet they are currently not active
> with
> > > it.
> > > But these particular PRs are more about documentation and fixing some
> > minor
> > > problems and do not require in-depth knowledge of python/gandiva part.
> > > So I think a quick check by gandiva people on the documentation part of
> > PR
> > > would be valuable.
> > >
> > >
> > > On Mon, Mar 29, 2021 at 7:51 AM Projjal Chanda <ia...@pchanda.com>
> wrote:
> > >
> > > > Hi Micah, Will,
> > > > I will review all the open C++/Java Gandiva PRs. Regarding the
> > > > [python][gandiva] PRs, I can take a look but its better if someone
> > > familiar
> > > > with it also reviews it.
> > > >
> > > > Thanks,
> > > > Projjal
> > > >
> > > > > On 29-Mar-2021, at 10:24 AM, Will Jones <wi...@gmail.com>
> > > wrote:
> > > > >
> > > > > Hi Vivek,
> > > > >
> > > > > The 18 PRs have the label "gandiva" in GitHub. Link:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/arrow/pulls?q=is%3Aopen+is%3Apr+label%3Agandiva
> > > > >
> > > > > Best,
> > > > > Will
> > > > >
> > > > >
> > > > > On Sun, Mar 28, 2021 at 9:38 PM Vivekanand Vellanki <
> > vivek@dremio.com>
> > > > > wrote:
> > > > >
> > > > >> Micah, Is there a link where I can look at all the open Gandiva
> > PRs? I
> > > > will
> > > > >> update the thread with the list of PRs we are reviewing.
> > > > >>
> > > > >> On Mon, Mar 29, 2021 at 9:22 AM Micah Kornfield <
> > > emkornfield@gmail.com>
> > > > >> wrote:
> > > > >>
> > > > >>> Hi Vivek,
> > > > >>> Does this apply to only PRs your team is opening or all open
> > Gandiva
> > > > PRs?
> > > > >>>
> > > > >>> Thanks,
> > > > >>> Micah
> > > > >>>
> > > > >>> On Thu, Mar 18, 2021 at 10:49 PM Vivekanand Vellanki <
> > > vivek@dremio.com
> > > > >
> > > > >>> wrote:
> > > > >>>
> > > > >>>> Micah,
> > > > >>>>
> > > > >>>> My team is looking at the PRs. We are giving feedback.
> > > > >>>>
> > > > >>>> We are also in touch with the committers (Ravindra and Praveen)
> > and
> > > > will
> > > > >>>> get them merged.
> > > > >>>>
> > > > >>>> Thanks
> > > > >>>> Vivek
> > > > >>>>
> > > > >>>> On Fri, Mar 19, 2021 at 9:29 AM Micah Kornfield <
> > > > emkornfield@gmail.com>
> > > > >>>> wrote:
> > > > >>>>
> > > > >>>>> Is anybody actively looking at PRs for Gandiva?  There seems to
> > be
> > > > >> queue
> > > > >>>>> building 18 (or so open).  The committers that seemed to be
> > active
> > > in
> > > > >> the
> > > > >>>>> past don't seem to be responding to pings through Github.
> > > > >>>>>
> > > > >>>>> Thanks,
> > > > >>>>> Micah
> > > > >>>>>
> > > > >>>>
> > > > >>
> > > >
> > > >
> > >
> > > --
> > > Best regards,
> > > Kirill Lykov
> > >
> >
>


-- 
Best regards,
Kirill Lykov