You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Andrew Black <ab...@roguewave.com> on 2007/03/15 15:53:50 UTC
Re: svn commit: r518316 - /incubator/stdcxx/trunk/GNUmakefile
Greetings Martin.
I believe this change is causing compile failures on the legacy tests,
as there were still a few stray references to _RWSTD_USE_CONFIG within
the legacy source files. A grep of the source tree indicates that the
following legacy files contain these references:
include/test.h
iostream/27_bench.cpp
localization/22_codecvt.cpp
localization/22_codecvt_iso2022.cpp
localization/22_collate.cpp
localization/22_localedef.cpp
vector/vectorbl.cpp
I think the critical failure is coming from test.h, but I'm not certain.
I have a number of other things that I need to get done today, so I
don't know if I'll have a chance to get to this, but I thought I'd give
you a heads up on the failure so you can resolve it if I don't have a
chance before you do.
--Andrew Black
sebor@apache.org wrote:
> Author: sebor
> Date: Wed Mar 14 13:43:35 2007
> New Revision: 518316
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=518316
> Log:
> 2007-03-08 Martin Sebor <se...@roguewave.com>
>
> * GNUmakefile (CPPFLAGS): Removed -D_RWSTD_USE_CONFIG.
>
> Modified:
> incubator/stdcxx/trunk/GNUmakefile
>
> Modified: incubator/stdcxx/trunk/GNUmakefile
> URL: http://svn.apache.org/viewvc/incubator/stdcxx/trunk/GNUmakefile?view=diff&rev=518316&r1=518315&r2=518316
> ==============================================================================
> --- incubator/stdcxx/trunk/GNUmakefile (original)
> +++ incubator/stdcxx/trunk/GNUmakefile Wed Mar 14 13:43:35 2007
> @@ -522,9 +522,6 @@
> # full library filename (including suffix)
> LIBNAME = lib$(LIBBASE)$(LIBSUFFIX)
>
> - # add to enable config.h (alternate config mechanism)
> - CPPFLAGS += -D_RWSTD_USE_CONFIG
> -
> ifeq ($(DEPENDDIR),)
> DEPENDDIR=.depend
> endif
>
>
>
Re: svn commit: r518316 - /incubator/stdcxx/trunk/GNUmakefile
Posted by Martin Sebor <se...@roguewave.com>.
Andrew Black wrote:
> Greetings Martin.
>
> I believe this change is causing compile failures on the legacy tests,
> as there were still a few stray references to _RWSTD_USE_CONFIG within
> the legacy source files. A grep of the source tree indicates that the
> following legacy files contain these references:
> include/test.h
> iostream/27_bench.cpp
> localization/22_codecvt.cpp
> localization/22_codecvt_iso2022.cpp
> localization/22_collate.cpp
> localization/22_localedef.cpp
> vector/vectorbl.cpp
>
> I think the critical failure is coming from test.h, but I'm not certain.
> I have a number of other things that I need to get done today, so I
> don't know if I'll have a chance to get to this, but I thought I'd give
> you a heads up on the failure so you can resolve it if I don't have a
> chance before you do.
Thanks, I should be able to fix it fairly quickly. I had done a global
search and replace on the macro but I must have missed the legacy tests.
Martin
>
> --Andrew Black
>
> sebor@apache.org wrote:
>> Author: sebor
>> Date: Wed Mar 14 13:43:35 2007
>> New Revision: 518316
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=518316
>> Log:
>> 2007-03-08 Martin Sebor <se...@roguewave.com>
>>
>> * GNUmakefile (CPPFLAGS): Removed -D_RWSTD_USE_CONFIG.
>>
>> Modified:
>> incubator/stdcxx/trunk/GNUmakefile
>>
>> Modified: incubator/stdcxx/trunk/GNUmakefile
>> URL:
>> http://svn.apache.org/viewvc/incubator/stdcxx/trunk/GNUmakefile?view=diff&rev=518316&r1=518315&r2=518316
>>
>> ==============================================================================
>>
>> --- incubator/stdcxx/trunk/GNUmakefile (original)
>> +++ incubator/stdcxx/trunk/GNUmakefile Wed Mar 14 13:43:35 2007
>> @@ -522,9 +522,6 @@
>> # full library filename (including suffix)
>> LIBNAME = lib$(LIBBASE)$(LIBSUFFIX)
>>
>> - # add to enable config.h (alternate config mechanism)
>> - CPPFLAGS += -D_RWSTD_USE_CONFIG
>> -
>> ifeq ($(DEPENDDIR),)
>> DEPENDDIR=.depend
>> endif
>>
>>
>>
>
>